Bug 443527 - remove mac32 bit launcher from build
Summary: remove mac32 bit launcher from build
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 4.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: Mars M2   Edit
Assignee: Arun Thondapu CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 441691
  Show dependency tree
 
Reported: 2014-09-08 13:15 EDT by David Williams CLA
Modified: 2014-09-09 07:23 EDT (History)
2 users (show)

See Also:

Attachments
patch to remove module from POM (526 bytes, patch)
2014-09-08 13:15 EDT, David Williams CLA 		no flags Details | Diff
The second place to remove it is from the "executable feature" (708 bytes, patch)
2014-09-08 13:20 EDT, David Williams CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-09-08 13:15:12 EDT 
Created attachment 246841 [details]
patch to remove module from POM

The "lowest" place to do this is in the framework pom.
Comment 1 David Williams CLA 2014-09-08 13:16:37 EDT 
I advocate we do this for M2, so the change is introduced early.
Comment 2 David Williams CLA 2014-09-08 13:20:52 EDT 
Created attachment 246842 [details]
The second place to remove it is from the "executable feature"
Comment 3 Arun Thondapu CLA 2014-09-09 06:58:44 EDT 
Pushed the changes (including a change in features/org.eclipse.equinox.executable.feature/pom.xml apart from the two places mentioned by David) as https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=350046a78f5034000094aa52eaf46221fdd1be5b

David, I could not push the changes with you as the author of the commit for some reason (remote rejected), just wanted to clarify...
Comment 4 Markus Keller CLA 2014-09-09 07:08:36 EDT 
(In reply to Arun Thondapu from comment #3)
> David, I could not push the changes with you as the author of the commit for
> some reason (remote rejected), just wanted to clarify...

Yes, the process requirements are completely broken, and everybody with the powers to fix it just hides behind lawyers that also don't understand it.
See https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions#Bugzilla : You have to manually add a "Signed-off-by:" line for the author to the commit message.
Comment 5 Arun Thondapu CLA 2014-09-09 07:23:06 EDT 
(In reply to Markus Keller from comment #4)
> (In reply to Arun Thondapu from comment #3)
> > David, I could not push the changes with you as the author of the commit for
> > some reason (remote rejected), just wanted to clarify...
> 
> Yes, the process requirements are completely broken, and everybody with the
> powers to fix it just hides behind lawyers that also don't understand it.
> See
> https://wiki.eclipse.org/Development_Resources/
> Handling_Git_Contributions#Bugzilla : You have to manually add a
> "Signed-off-by:" line for the author to the commit message.

Ok, I'll keep that in mind but I don't remember having had to do it earlier (I could sign off on the commit and push it without any issues).

Anyway, will mark this bug as fixed now.