Bug 443419 - No check return value warning
Summary: No check return value warning
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: 1.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.3   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-05 11:01 EDT by Sebastien Douheret CLA
Modified: 2014-09-12 17:12 EDT (History)
0 users

See Also:

Attachments
patch proposal (743 bytes, patch)
2014-09-05 11:01 EDT, Sebastien Douheret CLA 		eugene: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastien Douheret CLA 2014-09-05 11:01:27 EDT 
Created attachment 246777 [details]
patch proposal

Is it possible to integrate attached patch to fix following Coverity warning ?
Thanks.

(3) Event check_return: 	Calling function "print_trace(int, char const *, ...)" without checking return value (as is done elsewhere 0 out of 7 times).
(4) Event unchecked_value: 	No check of the return value of "print_trace(0, "Reply error %d: %s\n", error, tcf_errno_to_str(error))".

102  			trace(LOG_ALWAYS, "Reply error %d: %s\n",
103  			      error, errno_to_str(error));
Comment 1 Eugene Tarassov CLA 2014-09-05 18:49:08 EDT 
The patch causes build error:

tcf/main/main.c: In function ‘void check_idle_timeout(void*)’:
tcf/main/main.c:105:91: error: third operand to the conditional operator is of type ‘void’, but the second operand is neither a throw-expression nor of type ‘void’

I have committed slightly different change.

Fixed.
Thanks.
Comment 2 Sebastien Douheret CLA 2014-09-08 03:24:03 EDT 
Sorry didn't get this error our compiler.
Thanks a lot.