Bug 442781 - Wrong hyperlinks in stack trace console for entries with method signature
Summary: Wrong hyperlinks in stack trace console for entries with method signature
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 M3   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2014-08-28 06:16 EDT by Christian Georgi CLA
Modified: 2014-10-31 04:28 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Georgi CLA 2014-08-28 06:16:43 EDT 
SAP JVM adds JNI-style method signatures in stack traces as additional info.  Those entries are not properly recognized in stack trace console, leading to wrong hyperlinks.

Example stack entry:
  at java.util.concurrent.locks.LockSupport.parkNanos(Ljava/lang/Object;J)V(LockSupport.java:215)
as opposed to
  at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:196)
  
Change https://git.eclipse.org/r/#/c/32400/ adds support for these entries as well as tests for hyperlink detection.
Comment 1 Michael Rennie CLA 2014-10-08 13:43:13 EDT 
(In reply to Christian Georgi from comment #0)
 
> Change https://git.eclipse.org/r/#/c/32400/ adds support for these entries
> as well as tests for hyperlink detection.

Thanks for the fix Christian!, there are conflicts with the fix for bug 220657, so can you merge your fix with that one and submit a new gerrit change I can merge?
Comment 2 Christian Georgi CLA 2014-10-18 07:10:36 EDT 
(In reply to Michael Rennie from comment #1)
> (In reply to Christian Georgi from comment #0)
>  
> Thanks for the fix Christian!, there are conflicts with the fix for bug
> 220657, so can you merge your fix with that one and submit a new gerrit
> change I can merge?

Done
Comment 4 Sarika Sinha CLA 2014-10-29 03:02:03 EDT 
Christian,
Can you verify the bug resolution with SAP JVM ?
Comment 5 Christian Georgi CLA 2014-10-31 04:28:16 EDT 
(In reply to Sarika Sinha from comment #4)
> Christian,
> Can you verify the bug resolution with SAP JVM ?

Verified with one of the latest nightly builds.