Bug 44272 - retitle warning to "circular {advice} dependency at ..."
Summary: retitle warning to "circular {advice} dependency at ..."
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: 1.1.1   Edit
Hardware: PC Windows NT
: P3 enhancement (vote)
Target Milestone: 1.2   Edit
Assignee: Adrian Colyer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-07 00:05 EDT by Wes Isberg CLA
Modified: 2004-03-15 12:33 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wes Isberg CLA 2003-10-07 00:05:59 EDT 
When writing aspects with cycles in the advice precedence, get warning "circular
dependency at {join point}" -- should be "circular advice dependency..." or
"circular advice precedences at {join point} -- reorder the advice in the aspect".

FWIW, here's an example of circularity in advice precedence:
----
aspect A {
    pointcut crun() : execution (void run()) ;
    before() : crun() {}
    after() returning : crun() {}
    void around() : crun() { proceed(); }
}
----

See programming guide for more discussion of circularity in advice precedence.
Comment 1 Adrian Colyer CLA 2004-02-19 09:30:23 EST 
This will be an easy change to incorporate in 1.2
Comment 2 Adrian Colyer CLA 2004-03-15 12:33:20 EST 
Fixed in tree:

sample new message:
C:\ColyerRoot\...\tests\bugs\CircularAdvicePrecedence.java:6:0 circular advice 
dependency at method-execution(void Runner.run())

also fixed a related problem whereby the message for declare precedence 
circularities was out of date:
FROM: circularity in declare dominates, '*' occurs more than once
TO: circularity in declare precedence, '*' occurs more than once