Community
Participate
Working Groups
Created attachment 246155 [details] screenshot The Sirius specification editor sometimes inverts colors quite strange (see attachment). Steps to reproduce: 1) open sirius Specification editor 2) select one tree element 3) switch focus to another viewpart 4) click mouse on the still highlighted element in the spec. editor
Problem reproduced on Windows 7 with Sirius 1.0.1 (Luna) but not on Linux (Juno3 or Luna) nor on Mac (Kepler). This problem seems specific to Windows (only tested on Windows 7). Workaround: Put the mouse over "invisible" items reveal it.
We have the same problem with a simple ecore editor example, but not with the Sample Ecore Model Editor. The VSM (specification) editor and the simple ecore editor example are not generated with the last version of EMF. We must try to regenerate it to see if this resolves the problem.
Created attachment 246555 [details] Screen shot of balnk editor I am seeing this on Windows 8.1 in Luna 4.4. This can be reproduced 100% by selecting a tree node and then putting the focus on the Properties View in Eclipse and then reselecting the tree node.
seems to be a bigger issue as I see this in git staging view, too. Will raise a bug against platform/UI and link from here.
(In reply to Christian Pontesegger from comment #4) > seems to be a bigger issue as I see this in git staging view, too. Will > raise a bug against platform/UI and link from here. Yes, I'm seeing it on git staging view, too.
I've been doing some detective work on this. The problem is more obvious when you click on the tree in the Sirius Editor with a mouse click held for a slightly longer time. This suggests to me that something strange is happening with drag and drop. So, in the org.eclipse.sirius.editor.editorPlugin.SiriusEditor, in the methd: protected void createContextMenuFor(StructuredViewer viewer) if you comment out or remove this line: viewer.addDragSupport(dndOperations, transfers, new ViewerDragAdapter(viewer)); The color problem does not occur. I don't think that ViewerDragAdapter is the problem. I think the problem area is in the fact that drag support has been registered in the Viewer. But I don't know why this is like this.
raised platform/UI bug 443013
Thanks you for your analysis, we will follow this platform bug closely
*** Bug 451498 has been marked as a duplicate of this bug. ***
New Gerrit change created: https://git.eclipse.org/r/90402
The problem with the VSM editor is link to the following combination : - We use an EMF ViewPane using a SWT ViewForm encapsulating a JFace TreeViewer referencing a Tree with SWT.MULTI flag. - And the TreeViewer has the drag and drop support activated by using org.eclipse.jface.viewers.StructuredViewer.addDropSupport(int, Transfer[], DropTargetListener) Not using the SWT.MULTI flag on not using the drag and drop support or not using the ViewPane make it work. I did a draft were the bug is gone without loosing drag and drop or multi-selection : https://git.eclipse.org/r/#/c/90402/ I use in this patch the same construction than the EcoreEditor were no ViewPane is used. But we loose all other functionalities linked to the CustomSiriusEditor that is not used in the patch. I seems to me that it is an UI platform bug so I opened a ticket : https://bugs.eclipse.org/bugs/show_bug.cgi?id=511769
New Gerrit change created: https://git.eclipse.org/r/96393
(In reply to Eclipse Genie from comment #12) > New Gerrit change created: https://git.eclipse.org/r/96393 This is a workaround based on https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=052d5d66f0a1b483abcc639dc36dfb9820a326dc. It seems to "fix" the issue on the machines we tested it on. It's not perfect, there's a short visible "flash" when the tree is redrawn, but it's better than before. It does not seem to cause visible regressions when a different element than before is selected in the tree.
Gerrit change https://git.eclipse.org/r/96393 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fb0ec5ffc52dd0bb34bacb9e4662b03b04b0687f
Should be fixed by fb0ec5ffc52dd0bb34bacb9e4662b03b04b0687f. It's difficult to be completely sure as the bug can not always be reproduced, but I've merged the patch anyway; having it in M7 will make it easier to verify on the maximum number of machines.
Validated with Sirius 5.0.0.201705121003
Verified by Jessy.
Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.
