Bug 441763 - Avoid logging error from content assist when syntax error in manifest
Summary: Avoid logging error from content assist when syntax error in manifest
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2014-08-14 05:13 EDT by Marcel Bruch CLA
Modified: 2023-07-05 14:37 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Bruch CLA 2014-08-14 05:13:18 EDT
While triggering code completion in a manifest file I get the following error message "Error reading manifest for /Users/Marcel/Workspaces/codetrails/com.codetrails.connect.snippets2.rcp"


The cause of the error message is an invalid bundle header (in my case an comma in the last line of the required-bundle section:
...
 org.eclipse.xtext.xbase.lib;visibility:=reexport, << the comma
Bundle-ActivationPolicy: lazy


However, I think, the editor should just add an error marker at the right location instead of reporting the parsing error to the error log.




Some version information:



 pluginId=org.eclipse.pde.core
 pluginVersion=3.10.0.v20140519-1409
 eclipseBuildId=4.4.0.I20140606-1215
 javaRuntimeVersion=1.8.0-b132
 osgiWs=cocoa
 osgiOs=MacOSX
 osgiOsVersion=10.9.4
 osgiArch=x86_64
 severity=ERROR
 code=0
 message=Error reading manifest for /Users/Marcel/Workspaces/codetrails/com.codetrails.connect.snippets2.rcp
Comment 1 Curtis Windatt CLA 2014-08-14 16:33:57 EDT
Are there any error markers on the file?  We recently added some logic to create an error marker on the file if the manifest had a syntax error preventing Equinox from reading it.  The error returned doesn't typically return line information so we place the error at the start of the file.

If we are creating the error marker, the question becomes whether the content assist should fail silently under the assumption that the PDE builder will catch the bad syntax.
Comment 2 Marcel Bruch CLA 2014-08-14 18:35:57 EDT
(In reply to Curtis Windatt from comment #1)
> Are there any error markers on the file? 

Yes, in line 1 is an error marker.


> We recently added some logic to
> create an error marker on the file if the manifest had a syntax error
> preventing Equinox from reading it.  The error returned doesn't typically
> return line information so we place the error at the start of the file.

That's what I see.

> If we are creating the error marker, the question becomes whether the
> content assist should fail silently under the assumption that the PDE
> builder will catch the bad syntax.

I think so. The error is unnecessary. 


FWIW,
It's clearly not a tragedy. But the reason why I'm reporting this is, that I'm in the past 3 days I "produced" more than 900 error log entries [1] in Eclipse Luna. I'm now going through those errors I report those I think that can be fixed with the information I can provide right now... It would be great if this one could be fixed.



[1] http://recommenders.eclipse.org/dashboard/index.html#/dashboard/file/stacktraces.json
Comment 3 Eclipse Genie CLA 2019-07-24 10:28:05 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Eclipse Genie CLA 2021-07-14 01:48:39 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2023-07-05 14:37:30 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.