Bug 441659 - Remove the non-functional "Show more" button in Plugin Image browser
Summary: Remove the non-functional "Show more" button in Plugin Image browser
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.6 M4   Edit
Assignee: Elena Laskavaia CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2014-08-13 04:42 EDT by Christian Pontesegger CLA
Modified: 2015-12-08 00:49 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Pontesegger CLA 2014-08-13 04:42:46 EDT 
When clicking on "Show more" the image browser will display the same set of images from the same plugins all the time.

Expected behavior: advance through the plugins and show new images
Comment 1 Vikas Chandra CLA 2014-08-13 09:01:27 EDT 
I can recreate this behavior
Comment 2 Curtis Windatt CLA 2014-08-13 09:53:42 EDT 
Does it matter where the images are coming from? (workspace vs target)
Comment 3 Christian Pontesegger CLA 2014-08-13 11:53:19 EDT 
(In reply to Curtis Windatt from comment #2)
> Does it matter where the images are coming from? (workspace vs target)

same behavior for target and running application. Did not try with workspace
Comment 4 Eclipse Genie CLA 2015-09-09 22:45:35 EDT 
New Gerrit change created: https://git.eclipse.org/r/55603
Comment 5 Vikas Chandra CLA 2015-10-12 07:22:41 EDT 
On launching with the change I get 

Warning: NLS missing message: ImageBrowserView_ShowMore in: org.eclipse.pde.internal.ui.pderesources

	
public static String ImageBrowserView_ShowMore; 

should be removed.

Looks like the assessment in the gerrit patch is correct. 

According to me, it will be good to remove this button (However I'll double check today if we can do anything better than removing the button).
Comment 7 Vikas Chandra CLA 2015-11-02 03:41:36 EST 
Changed the bug's description and committed the patch.

Thanks Alena
Comment 8 Christian Pontesegger CLA 2015-11-06 06:45:49 EST 
Strange decision: instead of fixing its functionality we remove the button? So we now we can only see the first set of images. How would a user advance to further images?

Without that functionality the plugin gets almost useless
Comment 9 Elena Laskavaia CLA 2015-11-06 08:33:16 EST 
I added functionality of filtering, so instead of scrolling pages you can filter which reduces number of images and let you find what you actually is looking for

This button never meant to do pagination, if we do add pagination it will be 
a proper page controls (i.e. next page/previous page)
Comment 10 Christian Pontesegger CLA 2015-11-06 12:29:03 EST 
(In reply to Elena Laskavaia from comment #9)
> This button never meant to do pagination, if we do add pagination it will be 
> a proper page controls (i.e. next page/previous page)

Fair enough. Real pagination would be fine, so I created bug 481613.
Comment 11 Vikas Chandra CLA 2015-12-08 00:49:08 EST 
verified on

Version: Neon (4.6)
Build id: I20151207-0800