Bug 44155 - TODO tasks are miscategorized in Eclipse 3.0M3
Summary: TODO tasks are miscategorized in Eclipse 3.0M3
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: 1.2.1   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 1.5.0 M3   Edit
Assignee: Adrian Colyer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-10-03 16:05 EDT by Ron Bodkin CLA
Modified: 2012-04-03 16:04 EDT (History)
1 user (show)

See Also:


Attachments
Changes Log, based on AJDT 1.1.7 (1.79 KB, patch)
2004-04-13 08:32 EDT, Luzius Meisser CLA
aclement: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Bodkin CLA 2003-10-03 16:05:56 EDT
Eclipse 3.0 separates the notion of a task from a problem. The AJDT builder 
classifies TODO tasks as problems.
Comment 1 Luzius Meisser CLA 2004-04-13 08:32:22 EDT
Created attachment 9431 [details]
Changes Log, based on AJDT 1.1.7

CompilerMonitor now checks if warning message begins with TODO. If yes, the
marker created is of type TASK. Otherwise it creates, as before the patch, a
PROBLEM marker.
Version: AJDT 1.1.7, Eclipse 3.0 M8
Comment 2 Ron Bodkin CLA 2004-04-14 23:46:17 EDT
This sounds like a good step, although from the description it won't work with 
user-defined task tags (e.g., RBTODO: or FIX:). It also would get confused by 
declare warning/error messages that start with TODO (which isn't terribly 
important).
Comment 3 Andrew Clement CLA 2004-04-15 03:17:02 EDT
You are right Ron.  But without a AJ compiler change we don't have much info to 
differentiate between warnings coming back from the compiler and TODOs.  The 
lancaster codebase, which doesn't use AJDE, won't have this problem.  The best 
we *could* do right now is query the platform to determine the set of user 
defined task prefixes and any warnings coming out of the compiler that start 
with those prefixes are converted to TASKs.
Comment 4 Sian January CLA 2004-11-09 10:01:38 EST
Upon investigation Luzius's patch already looks for user defined tags, so the 
only remaining problem is declare warning or declare error statements that 
start with the same string as the name of a task tag.

The org.aspectj.bridge.IMessages passed to the CompilerMonitor from the 
AspectJ compiler have the kind WARNING for both warnings and tasks.  For tasks 
they should probably have the kind INFO. This therefore looks like an AspectJ 
bug so I am transferring the bug report.
Comment 5 Andrew Clement CLA 2005-05-05 06:37:36 EDT
I've checked in the AspectJ side of this just now - so messages of kind TASKTAG
will come out of AspectJ now when compiling.  I have a patch from Sian to do the
AJDT thing which I'll apply next time I build ajde.
Comment 6 Andrew Clement CLA 2005-06-08 09:13:35 EDT
this is fixed on the aj side...will be in M3.
Comment 7 Adrian Colyer CLA 2005-08-13 16:59:13 EDT
This bug was fixed in June!