Bug 441543 - Default the ID in a new product configuration file
Summary: Default the ID in a new product configuration file
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.7 M4   Edit
Assignee: Martin Karpisek CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2014-08-11 15:40 EDT by Lars Vogel CLA
Modified: 2016-12-05 17:20 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2014-08-11 15:40:44 EDT 
The Tycho build system requires that the ID is set in the product configuration file. It would be good if PDE could generate a default one. 

For example the generated content of the "name" field would be fitting IMHO for the default IDE.
Comment 1 Vikas Chandra CLA 2014-08-12 07:21:38 EDT 
Not sure if this is required especially after creating product file, cursor is in ID field only.

Or , if a product def file has to have an id, id field should be there in the previous dialog and finish should be disabled without a valid id.

I am not sure if generating a default name = "name" is the best way here.
Comment 2 Lars Vogel CLA 2014-08-12 07:23:08 EDT 
(In reply to Vikas Chandra from comment #1)
> Or , if a product def file has to have an id, id field should be there in
> the previous dialog and finish should be disabled without a valid id.

Sounds also good, maybe create a default ID in the previous dialog?
Comment 3 Curtis Windatt CLA 2014-08-12 09:49:16 EDT 
I'm fine with a default ID set in the creation dialog or a default ID in the editor if that field starts with focus and the default ID is selected (i.e. typing will delete the default ID).  The default ID should likely be based on the file name.  Reminder that the dialog cannot open with errors.

It should still be a simple operation to create a product config, open the dialog, select a project, enter a file name, press ok.
Comment 4 Vikas Chandra CLA 2014-08-13 00:59:58 EDT 
>default ID in the editor if that field starts with focus and the default ID is >selected (i.e. typing will delete the default ID).  The default ID should likely >be based on the file name.

I like this idea.

1)  Same as comment #0 
2) id field in focus and default id selected
3) typing deletes the default id
4) default id same as file name ( instead of "name" )

Lars, If you are you planning to contribute, we can put it in 4.5M2.
Comment 5 Lars Vogel CLA 2014-08-13 18:21:01 EDT 
(In reply to Vikas Chandra from comment #4)
> Lars, If you are you planning to contribute, we can put it in 4.5M2.

Sorry sure if I or Simon will find the time. We try.
Comment 6 Eclipse Genie CLA 2016-11-12 08:35:02 EST 
New Gerrit change created: https://git.eclipse.org/r/84927
Comment 8 Lars Vogel CLA 2016-11-15 16:20:01 EST 
Thanks Martin.
Comment 9 Vikas Chandra CLA 2016-12-05 04:27:04 EST 
Martin, can you please verify this fix?
Comment 10 Martin Karpisek CLA 2016-12-05 17:20:07 EST 
verified on:

Version: Oxygen (4.7)
Build id: I20161205-0800