Community
Participate
Working Groups
For stratum line breakpoints the property page currently does not show the condition editor. I understand the reasoning behind this, since in general there might be multiple Java locations for a single source line. But there are languages like Xtend where we have exactly one Java location that is statically known. For such cases it would be nice if the condition dialog was shown. Maybe this could be done via an additional marker attribute like "Java location". I would be happy to write a contribution for that. Maybe I'm also missing an existing possibility to do this. If so, just point me in the general direction =)
The condition editor (widgets and logic) is already API: org.eclipse.jdt.debug.ui.breakpoints.JavaBreakpointConditionEditor and is geared towards ILineBreakpoints - stratum breakpoints are extensions of line breakpoints, so it *should* be as simple as adding the editor to the desired property pages (emphasis on should). In reality, there will probably be work to do: 1. to resolve which Java location to 'use' (as you noted) 2. making sure content assist makes sense in the editor (when multiple locations are available)
(In reply to Michael Rennie from comment #1) > The condition editor (widgets and logic) is already API: Had a quick look at the code to refresh my memory, we could likely add a section in org.eclipse.jdt.internal.debug.ui.propertypages.JavaBreakpointPage.createTypeSpecificEditors(Composite) for stratum breakpoints, but we would have to ensure we don't bring back bug 325161
(In reply to Michael Rennie from comment #1) > In reality, there will probably be work to do: > 1. to resolve which Java location to 'use' (as you noted) I think a simple property on the stratum breakpoint interface would do. Users who know their Java location just set it and get the condition editor. > 2. making sure content assist makes sense in the editor (when multiple > locations are available) I don't think a single condition can make much sense with multiple locations. That's why I would like to show a condition editor only when there is exactly one Java location.
Created attachment 246313 [details] POC patch Here is a patch I was messing around with. It allows the editor to show on the property page and adds in a few extra fields in the top section. I didn't test it in any way, just wanted to see how easily the widgets could be shown.
Mike, Stephan, Anyone wants to complete this ? Do we want to put this in 4.5 M7 ? Otherwise we will have to move it out to 4.6 .
We worked around this for Xbase/Xtend, so having it in 4.6 would be enough from our point of view.
Moving it to 4.6
