Bug 440612 - Use StringBuilder instead of StringBuffer in Handle 'toString' methods
Summary: Use StringBuilder instead of StringBuffer in Handle 'toString' methods
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: Core (show other bugs)
Version: 0.1   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.2   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2014-07-29 03:45 EDT by Vladimir Piskarev CLA
Modified: 2014-09-03 01:23 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2014-07-29 03:45:01 EDT 
This StringBuffer usage was inherited from some old code, we should exterminate it from API (and implementation) until it is too late.
Comment 1 Vladimir Piskarev CLA 2014-07-29 04:01:51 EDT 
Note that this will break binary compatibility with the previous release (0.1). I think it's a reasonable trade-off in this case since there would be too many 'toString' methods to deprecate and we have been explicit in making no API promises for 0.1.
Comment 2 Vladimir Piskarev CLA 2014-07-29 04:07:59 EDT 
I forgot to add that migration path for existing clients should be very easy too.
Comment 3 Vladimir Piskarev CLA 2014-07-29 04:15:00 EDT 
Pushed to master.