Bug 439683 - Improve vxWorks support
Summary: Improve vxWorks support
Status: NEW
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-16 04:52 EDT by xavier pouyollon CLA
Modified: 2014-07-17 10:02 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xavier pouyollon CLA 2014-07-16 04:52:34 EDT 
Hi,

Improve vxWorks support of common.
Please see my proposal here:
https://git.eclipse.org/r/#/c/29817/

It has a severe drawback (by returning the Elf symbol, I'm loosing the type) but I can not find a better proposal.
Comment 1 xavier pouyollon CLA 2014-07-17 10:02:08 EDT 
Hi,

Got another proposal that keeps the type this time:
https://git.eclipse.org/r/#/c/30045/

If the common has been allocated, return it's address. Covers COMMON_MATCH_NONE
If the common hasn't been allocated, the search continues. Covers COMMON_MATCH_ALL.

In case the same common name is being allocated in several modules with different flag (COMMON_MATCH_NONE / COMMON_MATCH_ALL / COMMON_MATCH_USER), behaviour might be unexpected (first match is returned) but that should cover most the cases.