Bug 439370 - [category] - when specifying artifacts to track for download stats, should versions be specified?
Summary: [category] - when specifying artifacts to track for download stats, should ve...
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 426532
Blocks:
  Show dependency tree
 
Reported: 2014-07-10 15:11 EDT by Susan McCourt CLA
Modified: 2014-12-18 13:59 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2014-07-10 15:11:56 EDT
This idea came from bug 426532. When that bug is committed, the category editor will support the specification of a download stats server as well as the artifacts to track. For now, the user has to specify what version of artifact is to be tracked. Is this too restrictive?
Should versions be ignored?
Or should the user be able to say whether versions matter?

If we decide that versions don't matter, there will be a little refactoring to do with the interfaces in org.eclipse.pde.internal.core.ifeature and org.eclipse.pde.internal.core.ibundle. Currently both interfaces implement IVersionable. We would need non-versionable implementations that the download stats could use, and then clients who need versions would add it. If we go down this path, we should also consider whether to drop the URL in the basic feature model (because it is not used for stats tracking either) and use only when needed.
Comment 1 Curtis Windatt CLA 2014-07-10 17:06:48 EDT
I was hoping the model/interface changes would only affect the site/category models, not core IBundle and IFeature.  We need to be a more careful making changes there as they are used throughout PDE.
Comment 2 Susan McCourt CLA 2014-07-10 19:15:08 EDT
(In reply to Curtis Windatt from comment #1)
> I was hoping the model/interface changes would only affect the site/category
> models, not core IBundle and IFeature.  We need to be a more careful making
> changes there as they are used throughout PDE.

That's why I was nervous about doing any refactoring. We can look at this closer once we determine if we want to remove the version support.
Comment 3 Susan McCourt CLA 2014-07-26 12:48:14 EDT
Another issue that came up in bug 426532 is whether features should be sorted in the category.xml file. For example, if we no longer used feature URL when writing features for download stats, we would likely sort by id.