Bug 439248 - Gerrit Configuration... presets wrong push uri
Summary: Gerrit Configuration... presets wrong push uri
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-09 10:33 EDT by Dani Megert CLA
Modified: 2015-06-30 15:54 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2014-07-09 10:33:08 EDT
org.eclipse.egit.ui_3.4.0.201406032316.

1. clone ssh://git.eclipse.org/gitroot/jdt/eclipse.jdt.ui.git
2. select Remotes > origin
3. context menu > Gerrit Configuration...

==> push uri containt 'gitroot' which is wrong and will not work. One has to manually remove 'gitroot'.

This is major since new users will not be able to figure out what's wrong.
Comment 1 Matthias Sohn CLA 2014-07-09 10:47:20 EDT
If you clone from gitroot how should EGit know where to find Gerrit ? 
Or do you want to hardcode this for the git / Gerrit servers hosted by Eclipse ?
Comment 2 Dani Megert CLA 2014-07-09 13:02:19 EDT
(In reply to Matthias Sohn from comment #1)
> If you clone from gitroot how should EGit know where to find Gerrit ? 

Can I clone otherwise? How should a new user know it?

If there's no other way, then we should probably hard-code it. How does the wizard work with other repositories?
Comment 3 Markus Keller CLA 2014-08-11 07:35:24 EDT
(In reply to Matthias Sohn from comment #1)
> If you clone from gitroot how should EGit know where to find Gerrit ?

Is there a Gerrit convention for mapping repo urls?
- Either there is a convention that eclipse.org doesn't follow
   => fix eclipse.org (e.g. by supporting urls with the /gitroot/ path).
- Or the dialog should be more explicit about the problem and offer a "Test" button to check the url.
Comment 4 Matthias Sohn CLA 2014-09-03 10:51:11 EDT
(In reply to Dani Megert from comment #2)
> (In reply to Matthias Sohn from comment #1)
> > If you clone from gitroot how should EGit know where to find Gerrit ? 
> 
> Can I clone otherwise? How should a new user know it?

git clone https://git.eclipse.org/r/path/to/repo

http://git.eclipse.org/ could be configured by webmaster to give a hint that if a user wants to use Gerrit they should clone from the corresponding Gerrit URL.

> If there's no other way, then we should probably hard-code it. How does the
> wizard work with other repositories?

As Gerrit is a (JGit based) git server there is no need to run a native git daemon under a different URL. The Eclipse Foundation runs Gerrit and native git daemon independently under different URLs. We can't hardcode that since other organizations either don't run a native git daemon or run it under a different URL.
Comment 5 Mykola Nikishov CLA 2015-06-30 15:54:55 EDT
[Batch change] Remove pre-3.7 Target Milestones

If anyone on CC list is going to fix/implement this, please assign a new 3.7+ target milestone.