Comment 1 Philipe Mulet 2003-09-29 17:46:58 EDT

The problem lies on the UI side. After the commit operation, the 
resource got updated correctly, but the editor fails to notice this and 
persists in showing the dirty indicator. 
If switching to a different window and returning to editor window, then it will 
prompt to reload the file change.

Comment 2 Dani Megert 2003-09-30 04:55:45 EDT

We verified that we setup the buffer correctly on connect. The save however does
not get called on that buffer for non-build path files. Do you save to the right
buffer?

Set a breakpoint in DocumentAdapter2.save(...) and save a normal CU and a
non-build-path CU to see the difference

Comment 3 Philipe Mulet 2003-09-30 05:42:46 EDT

Agreed. This was a long standing bug. When a working copy isn't on the 
classpath, we never saved the buffer, but rather updated the resource directly.

Now you removed the document explicit save, this became visible. 

All commit situations will now properly enforce the buffer is officially saved.
Fixed (released for integration build > 20030930, since needs extra testing).

Comment 4 Philipe Mulet 2003-09-30 05:43:25 EDT

Fixed

Comment 5 Philipe Mulet 2003-09-30 05:54:01 EDT

Just to clarify, this has nothing to do with using working copy owners on our 
end, but rather a consequence of UI code having removed the document explicit 
save when they use wc owners.

Comment 6 Dani Megert 2003-09-30 05:54:41 EDT

can you provide a preview after todays I-build?

Comment 7 Dani Megert 2003-09-30 05:58:37 EDT

The new working copy handling had a new contract (commitWorkingCopy instead of
commit) and we assumed it to be correct that's why we never saved in that code path.

Comment 8 Philipe Mulet 2003-09-30 06:13:19 EDT

They are quite the same actually. Will post a preview as soon as it passes our 
tests (4 failures at the moment).

Comment 9 Jerome Lanneluc 2003-10-01 12:57:33 EDT

Preview posted on JDT/Core page.

Comment 10 David Audel 2003-10-10 05:16:58 EDT

Verified.