Community
Participate
Working Groups
If plugin is referenced from feature, the feature is not found by search for plugin references. Steps to reproduce: 1. Create a plugin 2. Create a feature including plugin 3. Open dialog Search/Plug-in 4. Enter plugin name, select "Search For/Plugin", "Limit To/References", "External Scope/All", "Scope/Workspace" 5. Press ok 6. Search view pops up Actual result: No items are shown in search result Expected result: Feature name is shown in search results allowing easy navigation to the feature editor with double click.
New Gerrit change created: https://git.eclipse.org/r/82788
Created attachment 264743 [details] Screenshot of how patch works what to setup in search for plugin and what will be shown in search results (in addition for features-plugins references)
Gerrit change https://git.eclipse.org/r/82788 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=62857b7759745e1cb1f8a025d3ff57b63eb354ff
Thanks Martin According to my testing, it looks fine. Code looks good too. Lars, Please have a look once you are back. If you still see an issue related to this patch, we can probably roll-back the fix.
Hi Vikas & Lars, thanks for considering the patch and merging. Just a note that I was trying to reproduce Lars exception, however it is seemed to me like probably different bug unrelated to the bugfix. Same exception stack happened for me in case, but not any more today:), from my notes (also i came to quite complex scenario, ithink): - org.eclipse.pde.apitools.test.oldshape (from PDE tests) was included from workspace in new runtime, - and target platfrom was without "Eclipse 2.0 Style Plugin Support for running old Eclipse plugins that are not proper OSGi bundles." - and i started completely new runtime platform (clean workspace=true) - and did completely no action after startup - just go to search and enter plugin search for org.eclipse.swt plugin,references (situation seemed like platfrom would try to resolve model for very first time) - only the first execution situation would lead to same stack trace exception (i put breakpoint to condition for logging), and looking immediately at that time on target platfrom in preferences would show error resolving "org.eclipse.pde.apitools.test.oldshape" - in log i saw !MESSAGE Plug-in at 'D:\home\git\eclipse.pde.ui\apitools\org.eclipse.pde.api.tools.tests\test-builder\usageprojects\org.eclipse.pde.apitools.test.oldshape' does not have an OSGi bundle manifest. To use a 2.0 style plug-in you must install the plug-in converter service. Go to Help > Install New Software and install 'Eclipse 2.0 Style Plugin Support' from 'The Eclipse Project Updates' software site - if i retry the search (just more search) on same running instance of eclipse it will somehow not get into the same situation, in target platfrom of runtime i can see that "oldshape" plugin not displayed as problem - at same time i logged exception what reported lars (unresolved plugin) - i did not continued in investigation at that day.. but today when i tried to retry again for verification (i tried add and remove that Eclipse 2.0 stle support), i am not able to reproduce the problem again and search for features somehow just works also in this condition... => i think it is some unusual situation on very first initialization of model of plugins in empty workspace/runtime + search action execution at same time (maybe..), and i guess this patch does not touch such code -> so should be ok
>>i guess this patch does not touch such code -> so should be ok +1 and hence I merged this patch. Since Lars is away this week, may be he can do some testing later on.
Vikas or Martin, please add this to the N&N M3.
I will add the item today.
Works fine but if I rename the plugin's name by adding an underscore, the dependent plugin is updated but the feature included plugin is not updated. This warrants a separate bug. Verified fixed on Version: Oxygen (4.7) Build id: N20161022-1500
Opened Bug 506542
Martin , I have updated N&N. Please see if it is ok. You can update contents directly or post the text/img on this bug. I will update it. N&N items are at gitroot/www.eclipse.org/eclipse/news.git
Vikas, i checked N&N description and it looks good for me. Thank you for making it.
