Bug 438373 - [patch] PDE product build speed degradation when building large classpaths
Summary: [patch] PDE product build speed degradation when building large classpaths
Status: RESOLVED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2014-06-27 06:30 EDT by Selene Feigl CLA
Modified: 2018-12-03 09:11 EST (History)
1 user (show)

See Also:


Attachments
Workaround for build speed degradation (2.49 KB, patch)
2014-06-27 06:30 EDT, Selene Feigl CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Selene Feigl CLA 2014-06-27 06:30:57 EDT
Created attachment 244590 [details]
Workaround for build speed degradation
Comment 1 Selene Feigl CLA 2014-06-27 06:38:37 EDT
Hi,

after the release of Luna I tried do build a large RCP product which was usually built with Indigo.

Building the product with Luna takes approx. 4-5 times longer compared to Indigo due to a very long time "Generating build scripts". In Indigo, the build script creation phase took about 1 minute and the remaining steps took about 3 minutes. In Luna, the build script creation takes about 16!! minutes, the remaining steps are as fast as in Indigo.

I must admit that the product has a more than suboptimal class path structure - cleanup is in progress but will take time. All 3rd party libraries which are no plugins are wrapped in a single plugin. This plugin is used by many of the RCP plugins.

I narrowed down the hot spot which caused the slow down. The string concatenation seems to be problematic for long strings and I suppose that this method is called very often.

My workaround caches the "rules" and the speed degradation is gone.

Is it possible to add this or something similar to Eclipse?

If requested, I could try to create an uploadable / open source licensed package that can reproduct the problem after my holidays about in one week.
Comment 2 Curtis Windatt CLA 2014-07-02 10:17:41 EDT
Moving from Indigo to Luna is quite the jump, it would be better to know what change caused the performance hit.  No one is actively working on PDE Build, but your proposed change looks reasonable at first glance.  Hopefully we will have time to investigate further in 4.5.  An example product to reproduce would be helpful.
Comment 3 Curtis Windatt CLA 2014-12-18 13:11:18 EST
Dropping from 4.5 as there is no one working on PDE Build and there is no example to reproduce the slowdown.
Comment 4 Lars Vogel CLA 2018-12-03 09:11:20 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 5 Lars Vogel CLA 2018-12-03 09:11:52 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.