Bug 438294 - Checks is not optional
Summary: Checks is not optional
Status: ASSIGNED
Alias: None
Product: LDT
Classification: Tools
Component: Metalua (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 major
Target Milestone: ---   Edit
Assignee: Kevin KIN-FOO CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-26 11:41 EDT by Kevin KIN-FOO CLA
Modified: 2014-09-30 10:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin KIN-FOO CLA 2014-06-26 11:41:15 EDT 
When you install only `metalua-compiler` as it is the case for luadocumentor, you can't require `checks`.

It is not part of rock-worthy files nor in rock list dependency.
Comment 1 Kevin KIN-FOO CLA 2014-06-26 11:54:34 EDT 
I remember that /checks.lua is a portable version of rocks. But I can see some problems coming.

Adding /checks.lua to exported modules in rockspec:

* There will be two checks modules in the path when installing package `Metalua`
    * Loaded one may vary

Adding `checks` dependency to all rockspecs:

* GCC will be needed to install `Metalua*` packages

Fabien, what do you think?
Comment 2 Kevin KIN-FOO CLA 2014-09-30 10:18:02 EDT 
What we could do is rename _checks.lua_ to _portablechecks.lua_ and do not require checks rock at all.

Then in the code we'll require 'portablechecks.lua' only when require 'checks' fails.

Does it sound good to you?