Community
Participate
Working Groups
Created attachment 244399 [details] Short "Product Version" field. Fedora 18, 64 bit The "Product Name" field on the "Product" page on the Oomph Installer is too short. I'll see about contributing a patch...
That looks odd. Unfortunately I don't have a linux box and I'm not able to test or fix this. I'm going to attach a screenshot of how it looks on Windows...
Created attachment 244400 [details] Installer on Windows
It would be great if soneone who can actually test the UI on Linux could help here.
Created attachment 247554 [details] It's fixed! It appears to be fixed in 1.0.0 build 490.
It doesn't look like you've been messing around in that code, so I'm not sure if you fixed it. Based on a cursory review, it looks like you're using the GridLayout in a very normal/standard/straight-forward way. I did upgrade to Fedora 20, so that may have been the solution. If that's the case, then I'm not sure what you can do about it.
Very good. And thanks for the feedback.
Well... it's back. After some further exploration, it appears to be either a bug or a feature of GTK (maybe a GTK3 thing). If I set an input on all of the combo boxes that provides at least one item, they size correctly. I'll experiment a bit with some options to see if we can apply a reasonable means of providing a reasonable default input into these fields without screwing up the rest of the programme flow.
I changed the logic so that there is always an input and at least one choice. http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=981ab454976cf9eeee5cfc7e4a58227fc385bb5d It has no visible impact on Windows because the combo is disabled when no product is selected so you can't see nor choose the one version choice. I did not test on Linux, but given your exploration, this should in theory fix the problem.
Created attachment 252736 [details] JVM selection combo is too short I'm still seeing this in the 4/24 downloads. I'll take a closer look.
This will be fixed in a similar way as the originally reported problem with the product version field...
I wasn't able to reproduce this but I've tried to fix it using the same approach as the previous time, i.e., ensure that the list of choices isn't empty during the initial layout. http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=934b0b2c16ac63b5cd35d459c4586c5480cd6c29