Bug 437850 - [Linux] The product version field isn't tall enough
Summary: [Linux] The product version field isn't tall enough
Status: RESOLVED FIXED
Alias: None
Product: Oomph
Classification: Tools
Component: Setup (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ed Merks CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 431425
Blocks:
  Show dependency tree
 
Reported: 2014-06-20 22:49 EDT by Wayne Beaton CLA
Modified: 2015-05-04 10:50 EDT (History)
1 user (show)

See Also:


Attachments
Short "Product Version" field. (76.75 KB, image/png)
2014-06-20 22:49 EDT, Wayne Beaton CLA
no flags Details
Installer on Windows (33.40 KB, image/png)
2014-06-21 06:15 EDT, Eike Stepper CLA
no flags Details
It's fixed! (115.63 KB, image/png)
2014-10-01 23:10 EDT, Wayne Beaton CLA
no flags Details
JVM selection combo is too short (91.77 KB, image/png)
2015-04-24 09:41 EDT, Wayne Beaton CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2014-06-20 22:49:14 EDT
Created attachment 244399 [details]
Short "Product Version" field.

Fedora 18, 64 bit

The "Product Name" field on the "Product" page on the Oomph Installer is too short.

I'll see about contributing a patch...
Comment 1 Eike Stepper CLA 2014-06-21 06:14:35 EDT
That looks odd. Unfortunately I don't have a linux box and I'm not able to test or fix this. I'm going to attach a screenshot of how it looks on Windows...
Comment 2 Eike Stepper CLA 2014-06-21 06:15:00 EDT
Created attachment 244400 [details]
Installer on Windows
Comment 3 Eike Stepper CLA 2014-10-01 13:22:46 EDT
It would be great if soneone who can actually test the UI on Linux could help here.
Comment 4 Wayne Beaton CLA 2014-10-01 23:10:16 EDT
Created attachment 247554 [details]
It's fixed!

It appears to be fixed in 1.0.0 build 490.
Comment 5 Wayne Beaton CLA 2014-10-01 23:23:17 EDT
It doesn't look like you've been messing around in that code, so I'm not sure if you fixed it. Based on a cursory review, it looks like you're using the GridLayout in a very normal/standard/straight-forward way.

I did upgrade to Fedora 20, so that may have been the solution. If that's the case, then I'm not sure what you can do about it.
Comment 6 Eike Stepper CLA 2014-10-02 00:49:26 EDT
Very good. And thanks for the feedback.
Comment 7 Wayne Beaton CLA 2015-03-15 22:09:05 EDT
Well... it's back. After some further exploration, it appears to be either a bug or a feature of GTK (maybe a GTK3 thing). 

If I set an input on all of the combo boxes that provides at least one item, they size correctly.

I'll experiment a bit with some options to see if we can apply a reasonable means of providing a reasonable default input into these fields without screwing up the rest of the programme flow.
Comment 8 Ed Merks CLA 2015-04-03 02:39:17 EDT
I changed the logic so that there is always an input and at least one choice.

http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=981ab454976cf9eeee5cfc7e4a58227fc385bb5d

It has no visible impact on Windows because the combo is disabled when no product is selected so you can't see nor choose the one version choice.  I did not test on Linux, but given your exploration, this should in theory fix the problem.
Comment 9 Wayne Beaton CLA 2015-04-24 09:41:14 EDT
Created attachment 252736 [details]
JVM selection combo is too short

I'm still seeing this in the 4/24 downloads. I'll take a closer look.
Comment 10 Eike Stepper CLA 2015-05-03 06:15:19 EDT
This will be fixed in a similar way as the originally reported problem with the product version field...
Comment 11 Ed Merks CLA 2015-05-04 10:50:47 EDT
I wasn't able to reproduce this but I've tried to fix it using the same approach as the previous time, i.e., ensure that the list of choices isn't empty during the initial layout.

http://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=934b0b2c16ac63b5cd35d459c4586c5480cd6c29