Community
Participate
Working Groups
Repair action should not save the session when the user choice is No. In this case the expected behavior is to close the session without saving it. The issues comes from a wrong report. It has been introduced by commit 825388b5e120bfe30c75e8bf0539bf1736fadc23 (2013-09-18 09:58:41) Report recent code changes from the previous code base. > if (saveSessions) { > session.save(); > } > session.close(); became > if (saveSessions) { > session.save(new NullProgressMonitor()); > } > session.save(new NullProgressMonitor()); instead of > if (saveSessions) { > session.save(new NullProgressMonitor()); > } > session.close(new NullProgressMonitor()); (as it was done in the Viewpoint repository, commit e4ba2e3c3989c89cb598e90d334523285809df35)
See https://git.eclipse.org/r/28315
Corrected by commit 3eb1bf031d64711399216968e119f890af8e9ed7
Steps to reproduce: . Open/create a session an a sample model. . Open/create a diagram, save . make a modification (move an element at the bottom right for example) . do not save, the editor should be dirty . right-clic on the aird -> repair . clic on No when the action asks to save the session . the repair is done . reopen the diagram . you must not see the modifications done after the save (step3). They must be reverted between choice No and repair.
Available in Sirius 2.0.0.
Removing the "backport" tag; this was indeed backported to Sirius 1.0.1 as bug 437542.