Community
Participate
Working Groups
= Steps to reproduce = * Open a target file based on p2 update sites with outdated feature versions in the target editor Observation: target editor shows error complaining about first non-existing feature it is unable to spot => OK * Select the p2 update site that contains to outdated feature in the target editor and click on the Update button Expected: a) Outdated features get updated b) Target editor becomes dirty c) Target editor starts a new attempt to resolve the target definition Actual: a), b): OK b): NOK, nothing happens and the previously displayed errors stay there Observation/workaround: When opening the target file in a text editor, increasing the sequence number in the <?pde ...> header by one and saving the file, the target editor restarts resolving and removes all previously displayed errors once the resolution process has been successfully completed.
The update button should be increasing the sequence number, this could have been broken with changes in 4.4 or something else may be affecting it.
Created attachment 244167 [details] File to recreate 1) Open the file attached in target definition editor 2) Click on the location. 3) Click update button on the side
Created attachment 244168 [details] Fix for this issue. Hi Curtis, Can you please look if this is the most optimum solution. There are other tools/functions like synchronizers (P2TargetUtils synchronizer = getSynchronizer(target);) and resolve but resetting Targeting location after an update seems the easiest way to solve this.
(In reply to Vikas Chandra from comment #3) > Created attachment 244168 [details] > Fix for this issue. > > Hi Curtis, Can you please look if this is the most optimum solution. There > are other tools/functions like synchronizers (P2TargetUtils synchronizer = > getSynchronizer(target);) and resolve but resetting Targeting location after > an update seems the easiest way to solve this. The only drawback to resetting the target locations is that it clears any cached information. Specifically it clears the cached features. All we want to update is the p2 locations, which is done via the sequence number. The easiest way to increment the sequence number is to call TargetDefinition.incrementSequenceNumber(). While I would prefer to use API methods, I think it makes more sense to directly call incrementSequenceNumber() over replacing all the target locations.
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?h=R4_4_maintenance&id=37afa4b85f29b7ff7c220cde378dd5dce1e96ddd Fixed in R4_4_maintenance Opened bug 438751 for the 4.5 fix. Vikas, please verify in a 4.4.1 M build.
(In reply to Curtis Windatt from comment #5) > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?h=R4_4_maintenance&id=37afa4b85f29b7ff7c220cde378dd5dce1e96ddd > > Fixed in R4_4_maintenance > > Opened bug 438751 for the 4.5 fix. > > Vikas, please verify in a 4.4.1 M build. where can I find a 4.4.1 build ?
*** Bug 439011 has been marked as a duplicate of this bug. ***
(In reply to Matthias Sohn from comment #6) > (In reply to Curtis Windatt from comment #5) > > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > > ?h=R4_4_maintenance&id=37afa4b85f29b7ff7c220cde378dd5dce1e96ddd > > > > Fixed in R4_4_maintenance > > > > Opened bug 438751 for the 4.5 fix. > > > > Vikas, please verify in a 4.4.1 M build. > > where can I find a 4.4.1 build ? We start the M-builds this Wednesday. You'll find them here: http://download.eclipse.org/eclipse/downloads/
Verified in Version: Luna SR1 (4.4.1) Build id: M20140827-1200
