Bug 436129 - [releng] several equinox weaving related bundles missing provider name
Summary: [releng] several equinox weaving related bundles missing provider name
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Weaving (show other bugs)
Version: 3.10.0 Luna   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: Luna RC4   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2014-05-28 20:42 EDT by David Williams CLA
Modified: 2014-06-02 03:42 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2014-05-28 20:42:49 EDT 
Not sure why I haven't seen these before ... probably because they have "equinox" in the name :) 

From a recent repo report, 
http://build.eclipse.org/simrel/luna/reporeports/reports/providerNames.html



org.eclipse.equinox.weaving.aspectj   1.0.400.v20131023-1256  
null
org.eclipse.equinox.weaving.aspectj.source   1.0.400.v20131023-1256  
unknown
org.eclipse.equinox.weaving.caching   1.0.400.v20131023-1256  
null
org.eclipse.equinox.weaving.caching.j9   1.0.200.v20131023-1256  
null
org.eclipse.equinox.weaving.caching.j9.source   1.0.200.v20131023-1256  
unknown
org.eclipse.equinox.weaving.caching.source   1.0.400.v20131023-1256  
unknown
org.eclipse.equinox.weaving.hook   1.1.0.v20131023-1256  
null
org.eclipse.equinox.weaving.hook.source   1.1.0.v20131023-1256  
unknown
Comment 1 Thomas Watson CLA 2014-05-29 13:27:17 EDT 
I'll take this one.
Comment 2 Martin Lippert CLA 2014-05-29 13:29:29 EDT 
Thanks, Tom, for taking care of this.
Comment 3 Thomas Watson CLA 2014-05-29 13:45:39 EDT 
Possible fix in gerrit:

https://git.eclipse.org/r/#/c/27549/

I noticed that none of the weaving bundles seem to translate the Bundle-Name or Bundle-Vender headers.  I'm not going to address that here.  Although I have always questioned the validity of making Bundle-Vender translatable.  Especially for the value "Eclipse.org - Equinox".  That does not seem like something you would ever want to translate.
Comment 4 Thomas Watson CLA 2014-05-29 13:47:57 EDT 
I should also mention that I took this opportunity to remove the "(Incubation)" part of the Bundle-Name.  Weaving bundles have been out of incubation for many releases.
Comment 5 David Williams CLA 2014-05-29 14:13:21 EDT 
(In reply to Thomas Watson from comment #3)
>  Although I
> have always questioned the validity of making Bundle-Vender translatable. 
> Especially for the value "Eclipse.org - Equinox".  That does not seem like
> something you would ever want to translate.

Oh, and how many languages do you speak/read? :) 
I don't disagree with you ... but, the way its always been explained to me is "you never know ... some country/language might want to" (But, I am NOT saying you "should address it now" ... just repeating what's been drummed into my head.)
Comment 6 Thomas Watson CLA 2014-05-29 14:31:07 EDT 
(In reply to David Williams from comment #5)
> (In reply to Thomas Watson from comment #3)
> >  Although I
> > have always questioned the validity of making Bundle-Vender translatable. 
> > Especially for the value "Eclipse.org - Equinox".  That does not seem like
> > something you would ever want to translate.
> 
> Oh, and how many languages do you speak/read? :) 
> I don't disagree with you ... but, the way its always been explained to me
> is "you never know ... some country/language might want to" (But, I am NOT
> saying you "should address it now" ... just repeating what's been drummed
> into my head.)

I understand that for things that are meant to be read, but things that are project names/identities/brands etc I don't think we should translate.  It would be like saying we need to translate IBM.  Just my 2c.