Bug 436094 - [CSS][Dark] Provide resonable PDE defaults for syntax color in Dark theme
Summary: [CSS][Dark] Provide resonable PDE defaults for syntax color in Dark theme
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.4 RC3   Edit
Assignee: Andrea Guarinoni CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2014-05-28 13:06 EDT by Andrea Guarinoni CLA
Modified: 2014-05-31 03:40 EDT (History)
5 users (show)

See Also:
daniel_megert: review+
Michael_Rennie: review+
curtis.windatt.public: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Guarinoni CLA 2014-05-28 13:06:00 EDT 
With Eclipse 4.4 projects can contribute styling to existing themes.

Would be nice to load suitable default values for XML and MF files in Dark theme.

More details in Bug 433475.
Comment 1 Andrea Guarinoni CLA 2014-05-28 13:13:07 EDT 
Patch proposal: https://git.eclipse.org/r/27488
Comment 2 Curtis Windatt CLA 2014-05-28 13:40:53 EDT 
Dani, I assume we should be considering this for RC3 inclusion similar to Debug.

Vikas, please review this asap.
Comment 3 Curtis Windatt CLA 2014-05-28 15:34:59 EDT 
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=0cd93d523e13847127999c82a624f8939ecbaa77
+1, fixed in master

Andrea, in the future, when creating the commit for gerrit, please put the 'Bug ######' at the start of the commit message, not on a new line.  This makes it a lot easier to track issues using git.eclipse.org and the eGit history view.
Comment 4 Andrea Guarinoni CLA 2014-05-28 16:41:51 EDT 
(In reply to Curtis Windatt from comment #3)
> http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/
> ?id=0cd93d523e13847127999c82a624f8939ecbaa77
> +1, fixed in master
> 
> Andrea, in the future, when creating the commit for gerrit, please put the
> 'Bug ######' at the start of the commit message, not on a new line.  This
> makes it a lot easier to track issues using git.eclipse.org and the eGit
> history view.

Ok thanks Curtis!

(I was using it because I saw that Matthias changed the commit message to that format in https://git.eclipse.org/r/#/c/26227/)
Comment 5 Dani Megert CLA 2014-05-29 05:48:31 EDT 
The "css" entry in the 'build.properties' file was missing a '/' and hence the style sheet is not part of the latest build (I20140528-2000). The copyright date was also not updated.

Fixed with http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=acbfa8dc72c68c9416bee071016432dbe25cc825
Comment 6 Dani Megert CLA 2014-05-31 03:40:15 EDT 
Verified in I20140530-2000.