Bug 435015 - [TERMINALS] Request "Show In -> Local Terminal"
Summary: [TERMINALS] Request "Show In -> Local Terminal"
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Target (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows 7
: P3 enhancement with 3 votes (vote)
Target Milestone: 1.3   Edit
Assignee: Uwe Stieber CLA
QA Contact: Uwe Stieber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 460062
  Show dependency tree
 
Reported: 2014-05-15 23:38 EDT by Paul Verest CLA
Modified: 2015-02-16 18:48 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Verest CLA 2014-05-15 23:38:45 EDT
"Show In" menu is available via right-click or Alt+Shift+W

Please add "Show In" Local Terminal option to that menu
Comment 1 Martin Oberhuber CLA 2014-05-16 03:55:44 EDT
Thanks Paul, this is a very good idea.

To be clear about the design:

1. Expectation of "Show In > Local Terminal" would be that you get a Terminal
   sitting at the directory of your current selection.
   I think we can't try re-using an existing Terminal since we cannot track
   its current directory nor influence the cwd of a running Terminal.
   Therefore, "Show In > Local Terminal" would always open a *new* Terminal.

2. With the "current working directory" set to the directory of given selection
   (eg folder of file in editor, folder of file selected in project explorer
   or package explorer)

3a. In case multiple local terminals are installed (eg Git Bash, MinGW, Cygwin
    as per your request in bug 435014), would you expect multiple "Show In >"
    contributions eg "Show In > Git Bash", "Show In > Cygwin Bash" ?

3b. Or would it be acceptable if there be a single "Show In > Local Terminal"
    with an additional dialog popping up to select the terminal type, in case
    multiple local terminals are installed ? - I guess it would just require
    an additional hit on the ENTER key to choose the Terminal type.

I'm really undecided whether 3a or 3b would be better in terms of usability.
Technically, we could do (3a) with static contributions + property testers.
(3b) might be slightly easier to implement and would have the advantage that
users could contribute their own additional favorite shell executables.

Paul, any initial comments on the design ?

Thanks,
Martin
Comment 2 Martin Oberhuber CLA 2014-05-18 07:57:01 EDT
I think the intuitive must-have expectation is having a single "Show In" > Local Terminal which doesn't ask back for any settings -- option 1 above, always opening a *new* Terminal. 

As an added nice-to-have, the opened terminal should have the basename of the selected folder in its title (as suggested on bug 434940). Show In > Local Terminal on the same selection should re-use the existing tab. Otherwise open a new Tab.

Multiple installed terminals (3a, 3b above) should be tracked in a separate bug, such that this enhancement request can be closed quickly.
Comment 3 Paul Verest CLA 2014-05-18 23:21:50 EDT
Yes, this is not single step issue. Bug 434940 (multiple Local Teminal) is to be worked out first.

Personally I think having to many options in "Show In" would make it worse. Can menu contribution be configured? e.g. 

Git Bash Path [           ]
[v] show Git Bash in "Show In" menu
Comment 4 Jörg Thönnes CLA 2014-06-26 05:22:04 EDT
This would be the same as for Windows Explorer SHIFT-RightClick on a folder "Open command ... here"

+1 Definitely an improvement for me.
Comment 6 Paul Verest CLA 2014-10-08 04:07:17 EDT
As said in https://bugs.eclipse.org/bugs/show_bug.cgi?id=435014#c14

3) While Eclipse "Shown In" menu has shortcut Alt+Shift+W, Terminals and Git Bash do not go into it, but with new menu with the same name "Shown In" (without shortcut). Also this second "Shown In" menu is not visible in Package Explorer that is default in Java perspective (note that in future Project Explorer is to replace Package Explorer as default everywhere)
Comment 7 Uwe Stieber CLA 2014-10-08 04:10:25 EDT
> 3) While Eclipse "Shown In" menu has shortcut Alt+Shift+W, Terminals and Git
> Bash do not go into it

The "Terminals" view, opening a local terminal, is contributed to the "Navigate > Show In" (or Alt+Shift+W) menu. There is an entry "Terminals". Things like "Git Bash" cannot be contributed to this menu because the Eclipse show in extension does allow the contribution of views only.
Comment 8 Paul Verest CLA 2014-10-09 12:20:20 EDT
(In reply to Uwe Stieber from comment #7)
> > 3) While Eclipse "Shown In" menu has shortcut Alt+Shift+W, Terminals and Git
> > Bash do not go into it
> 
> The "Terminals" view, opening a local terminal, is contributed to the
> "Navigate > Show In" (or Alt+Shift+W) menu. There is an entry "Terminals".


From what I saw in nightly version both "Terminals" and "Git Bash" were in "Show In" (without shortcut)


> Things like "Git Bash" cannot be contributed to this menu because the
> Eclipse show in extension does allow the contribution of views only.

If it can't be in "Show In" (with shortcut Alt+Shift+W), it at least should not create menu with the same name "Show In" (without shortcut) because that creates confusion. Name it differently e.g. "Open In" etc.

I also wonder why those terminals can't be standard Views, then they can be closed quickly, moved into Editors area etc, but that is other issue.
Comment 9 Lars Vogel CLA 2014-12-01 03:22:54 EST
Tried with 1.3.0.201405171650 org.eclipse.tcf.te.terminals.feature.feature.group from ttp://download.eclipse.org/tools/tcf/terminals_beta and it did not work.
Comment 10 Martin Oberhuber CLA 2014-12-01 13:19:58 EST
The May Beta is too old -- it does work from nightly master, see the docs here:
http://marketplace.eclipse.org/content/tcf-terminals#.VHyw-skzAa6
Comment 11 Martin Oberhuber CLA 2015-02-16 18:48:01 EST
I finally also see the issues mentioned in comment 6 -- I've filed bug 460062 for tracking it. Looks like the issue only occurs in the Java Perspective, or on projects that have a Java nature.