Bug 433869 - IQMakeProjectInfo is not updating IQMakeInfo when active configuration is changed only
Summary: IQMakeProjectInfo is not updating IQMakeInfo when active configuration is cha...
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-qt (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-30 12:12 EDT by David Kaspar CLA
Modified: 2020-09-04 15:26 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kaspar CLA 2014-04-30 12:12:57 EDT
How to reproduce:
1) Have a CDT/Qt project.
2) Use QMakeInfo API (to retrieve IQMakeProjectInfo for your project).
3) Add a listener on IQMakeProjectInfo.
4) Check if the listener is called when an active configuration is changed on the project.

Actual behavior:
Listener is not notified.

Expected behavior:
Listener is notified.

Implementation notes:
The root cause is in QMakeProjectInfoManager.start() method which registers

CoreModel.getDefault().addCProjectDescriptionListener(PD_LISTENER, ICDescriptionDelta.ACTIVE_CFG);

but it should be:
CoreModel.getDefault().addCProjectDescriptionListener(PD_LISTENER, CProjectDescriptionEvent.LOADED | CProjectDescriptionEvent.APPLIED);
Comment 1 David Kaspar CLA 2014-04-30 12:20:57 EDT
Fix available at:
https://git.eclipse.org/r/25808
Comment 2 Doug Schaefer CLA 2014-04-30 12:50:05 EDT
Thanks David. Did you want this applied to cdt 8.3 as well?
Comment 3 David Kaspar CLA 2014-04-30 14:29:59 EDT
(In reply to Doug Schaefer from comment #2)
> Thanks David. Did you want this applied to cdt 8.3 as well?

It would be nice to integrate it to cdt_8_3 but it is not critical - the issue is rather Minor in our current use-cases in MNTCS. If we would integrate it into cdt_8_3, I would rather do it after 2.1 Beta release. I will cherry-pick the patch #25808 to cdt_8_3 after the 2.1 Beta release. Thanks.
Comment 4 David Kaspar CLA 2014-05-09 07:08:11 EDT
Cherry-pick of the fix to cdt_8_3 branch is available at:
https://git.eclipse.org/r/25808
Comment 5 David Kaspar CLA 2014-05-09 07:09:29 EDT
(In reply to David Kaspar from comment #4)
> Cherry-pick of the fix to cdt_8_3 branch is available at:
> https://git.eclipse.org/r/25808

Correction:
https://git.eclipse.org/r/25808 - master branch
https://git.eclipse.org/r/26264 - cdt_8_3 branch