Bug 433839 - auto share performance issue with nested projects
Summary: auto share performance issue with nested projects
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 3.3.1   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-30 07:41 EDT by Martin Lippert CLA
Modified: 2019-07-22 15:51 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Lippert CLA 2014-04-30 07:41:49 EDT
I am importing a project with nested projects and the auto-share dialog runs for a very long time. This seems to happen if I import the root project as well as the nested projects only. If I import the nested projects only, performance is great.

I am using the "sagan" project to reproduce this issue (which someone reported while using STS). Here are the steps how to reproduce the issue:

https://github.com/spring-io/sagan/wiki/Import-into-IDEA-or-Eclipse

Would be great if someone could take a look. I quickly captured a few thread dumps while dia dialog is up for so long, but nothing unusual was in there that jumped right into my eye.
Comment 1 Matthias Sohn CLA 2014-04-30 08:25:16 EDT
Did you filter out the nested projects using resource filters when also importing the parent project ? We do this in jgit here : https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit.packaging/.project
Comment 2 Robin Stocker CLA 2014-04-30 10:23:26 EDT
Could you also please try if the problem also exists on EGit nightly from this update site?:

http://download.eclipse.org/egit/updates-nightly
Comment 3 Martin Lippert CLA 2014-05-04 08:24:39 EDT
I tried this with the latest nightly builds. The total time spend in auto-sharing is a lot less than before, but still an order of magnitudes slower than without importing the root project. Just importing the nested projects is almost instant, importing the root project as well increaes the overall time spend in auto-sharing dramatically.

From the progress messages it looks like most of the time is spend in refreshing the nested projects (for whatever reason).
Comment 4 Martin Lippert CLA 2014-05-04 08:26:53 EDT
(In reply to Matthias Sohn from comment #1)
> Did you filter out the nested projects using resource filters when also
> importing the parent project ? We do this in jgit here :
> https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit.packaging/.
> project

I don't do anything special here, since the Eclipse project metadata is generated from Gradle, but I could try to edit this manually for testing purposes.
Comment 5 Martin Lippert CLA 2014-05-04 09:38:49 EDT
(In reply to Martin Lippert from comment #4)
> (In reply to Matthias Sohn from comment #1)
> > Did you filter out the nested projects using resource filters when also
> > importing the parent project ? We do this in jgit here :
> > https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse.jgit.packaging/.
> > project
> 
> I don't do anything special here, since the Eclipse project metadata is
> generated from Gradle, but I could try to edit this manually for testing
> purposes.

I tried this and it doesn't improve performance while doing the auto sharing. So I think there is still something that goes wrong with regards to performance. The test case that I am using is pretty reliable and reproduces the problem:

https://github.com/spring-io/sagan/wiki/Import-into-IDEA-or-Eclipse

(if you want to try to reproduce this)
Comment 6 Shubhangi Wakodikar CLA 2019-07-22 15:51:47 EDT
I am facing a similar issue on Windows 10 with Eclipse-2019-06 version - 
When I import maven project (with nested projects inside it), after (automatic) building and everything, an automatic process called 'auto sharing git projects' starts to run and it runs for 7-8 hrs. Finally it fails and it looks like it will not do that process 'auto sharing git projects' again but I did not test after this. 
This maven nested project is importing fine on eclipse-2019-03 version.