Bug 433831 - Computed color on edge style description seems to take source finder expression as self, which is not very useful
Summary: Computed color on edge style description seems to take source finder expressi...
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2014-04-30 06:17 EDT by Charlie Mordant CLA
Modified: 2015-01-06 05:41 EST (History)
4 users (show)

See Also:

Attachments
sample viewpoint with computed color for edges (71.23 KB, application/x-zip-compressed)
2014-05-06 10:04 EDT, Charlie Mordant CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Mordant CLA 2014-04-30 06:17:16 EDT 
When basing a edge style color on computed color, it look like only the source finder expression element is available on red/green/blue computation expression.

It's not sufficient to compute an edge color: we must have access to its source and target.

$view could for example be accessible on color computation, or even associated elements expression result.

as an addition, color computation tooltips can list the available variables.
Comment 1 Esteban DUGUEPEROUX CLA 2014-05-05 03:49:40 EDT 
This improvement has been created following discussion from Sirius forum : http://www.eclipse.org/forums/index.php/t/722053/
Charlie, can you provide a project in attachement to reproduce your issue?

Seeing the sirius code, the computed color evaluation seems done in AbstractColorUpdater.getRGBValueForComputedColor() without setting variables to the interpreter.
Comment 2 Charlie Mordant CLA 2014-05-06 10:04:17 EDT 
Created attachment 242765 [details]
sample viewpoint with computed color for edges
Comment 3 Charlie Mordant CLA 2014-05-06 10:07:15 EDT 
Here's a sample.
If it worked, MyColorService.getMockedColor should have returned a 10,10,10 RGB