Bug 433497 - Commit Changes Dialog should show asterisk for files added to Index in Files table
Summary: Commit Changes Dialog should show asterisk for files added to Index in Files ...
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2014-04-25 05:51 EDT by Paul Verest CLA
Modified: 2014-04-28 02:18 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Verest CLA 2014-04-25 05:51:35 EDT
If I add files to index and immediately commit them, I see files with green plus overlay icon. That is nice.

However if I do add to Index twice or mote time, I cannot distinguish files that are added in Index from Commit Changes Dialog.
Comment 1 Robin Stocker CLA 2014-04-25 14:31:00 EDT
You're right, that would be nice.

By the way, do you know about the "Git Staging" view (use Ctrl+3 or Cmd+3 to find it)? It's much nicer than the Commit dialog for committing.
Comment 2 Paul Verest CLA 2014-04-27 22:41:10 EDT
(In reply to Robin Stocker from comment #1)
> 
> By the way, do you know about the "Git Staging" view (use Ctrl+3 or Cmd+3 to
> find it)? It's much nicer than the Commit dialog for committing.

Hi Robin

I knew (it was in some newer version announce), but have forgotten. Their functionality is similar.
While Commit Changes Dialog is easier to access, Git Staging View is non modal.

Please add Git Staging View in Team context menu as well.

P.S. there is some inconsistency: 
in Commit Changes Dialog unstaged files (that are called untracked files) are shown below, 
but in Git Staging View "Unstaged" files are shown above.
Comment 3 Paul Verest CLA 2014-04-28 02:18:27 EDT
P.P.S. Also there should be a way to switch between Commit Changes Dialog and Git Staging View. Currently there are 2 ways to commit, but they are not connected  with link.