Bug 433389 - Diagram not drawn correctly
Summary: Diagram not drawn correctly
Status: RESOLVED WORKSFORME
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.0M6   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2014-04-24 07:08 EDT by Cedric Gava CLA
Modified: 2014-05-27 10:40 EDT (History)
3 users (show)

See Also:


Attachments
Stack trace (14.95 KB, text/plain)
2014-04-24 07:09 EDT, Cedric Gava CLA
no flags Details
eclipse install description (7.39 KB, text/plain)
2014-04-24 07:10 EDT, Cedric Gava CLA
no flags Details
Sample project with a VSM and 2 ecores with diagrams (23.89 KB, application/zip)
2014-04-28 07:18 EDT, Pierre-Charles David CLA
no flags Details
Installation details for Luna M6 + Sirius 1.0.0M6 (1.40 KB, application/octet-stream)
2014-04-29 03:30 EDT, Pierre-Charles David CLA
no flags Details
bugging project (967.01 KB, application/x-zip-compressed)
2014-05-14 03:36 EDT, Cedric Gava CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Gava CLA 2014-04-24 07:08:23 EDT
Diagrams are not drawn correctly, 


Argument types mismatch for module element dynamicModuleQuery2
Comment 1 Cedric Gava CLA 2014-04-24 07:09:38 EDT
Created attachment 242281 [details]
Stack trace
Comment 2 Cedric Gava CLA 2014-04-24 07:10:33 EDT
Created attachment 242282 [details]
eclipse install description
Comment 3 Cedric Gava CLA 2014-04-24 07:16:59 EDT
At the moment, I am studying closely Sirius metamodel, and thus created viewpoints to study it.

How to reproduce the bug:

- Create a new workspace
- Create a viewpoint specification for an ecore metamodel, with a very simple diagram mapping (one node, graphic, for all the EPackage for example).
- Import sirius viewpoint.ecore - Add representation --> the nodes are drawn correctly
- Close eclipse, and reopen it again
- Only one box appears on the diagram

If you clear .metadata and recreate project sructures, then the bugs disappears as long as you don't close/open again

Tested (with the same installation) on a Linux x86_64 platform --> same bug

Hope this helps
Comment 4 Cedric Brun CLA 2014-04-24 09:05:45 EDT
Hi, do you have viewpoint.ecore in your workspace for some reason  ? That could confuse the Acceleo engine..
Comment 5 Cedric Gava CLA 2014-04-24 13:23:28 EDT
Hello Cedric
Thank you for your support 

Yes I exactly have THE viewpoint.ecore from last Sirius Milestone (simply because I'am using the sample ecore sirius editor to get ecore diagram from viewpoint/diagram/contribution metamodels)... in the workspace.

Something noticeable : as long as I don't close my eclipse, no problem.. As soon as I reopen, the bug prevents any diagram creation.

If this bug is not Critical for you, which I perfectly understand, maybe you can advise me some workaround to prevent me from deleting the entire .metadata folder.

Maybe shall I change the URI of the viewpoint.ecore in my workspace ?
Comment 6 Pierre-Charles David CLA 2014-04-28 07:18:28 EDT
Created attachment 242390 [details]
Sample project with a VSM and 2 ecores with diagrams

I could not reproduce the problem with this attached test case.

Steps used to reproduce:
1. Import the attached project into a fresh workspace with Sirius installed (I am using a current master, as of 2014-04-28). The project contains a simple VSM which shows packages and classes from Ecore models, 2 samples Ecore files (a very simple one, custome-made, and a copy of viewpoint.ecore) and 2 corresponding representation files. The VSM uses simple Acceleo expressions.
2. Right-click on simple.aird to open the session, expand the file and open the single diagram found inside.
3. Close Eclipse and restart it. It re-opens the session and diagram as it was before. Everything seems OK.
4. Repeat steps 2 & 3 using viewpoint.aird which has a diagram on the workspace copy of viewpoint.ecore. Everything works fine for me in that case too.

I have no errors or warnings in the error log either. I tried variant of this scenario using a project with the Modeling nature, and it still works fine, with both models.

I'll try again on a plain M6 to see if it is something which we have fixed since then.
Comment 7 Pierre-Charles David CLA 2014-04-28 07:33:03 EDT
I can not reproduce on a plain Luna M6 + Sirius 1.0M6 either. Can you give more details about your scenario and/or attach a sample project?
Comment 8 Cedric Gava CLA 2014-04-28 15:13:01 EDT
Hello

I will try ASAP your project.
I got the sources of ecore sample editor and the viewpoint scores (viewpoint,diagram and contribution)
I can send the workspace.

Can you attach your installation details (plugin and version) so I can compare how different is my installation.

Cheers
Cedric
Comment 9 Pierre-Charles David CLA 2014-04-29 03:30:29 EDT
Created attachment 242440 [details]
Installation details for Luna M6 + Sirius 1.0.0M6

I also tested with a current master (the closest would be the lastest nightly at http://download.eclipse.org/sirius/updates/nightly/latest/luna if you do not want to run from the sources), on top of the target platform found at http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/tree/releng/org.eclipse.sirius.targets/sirius_luna.target

Note that the sample project attached was created using the current master, which includes changes in the metamodel from the version in M6. If you want to use the sample using M6, you need to delete the two aird files and recreate new ones (right-click on each ecore in turn and select "New > Representation file"). Using models created with M6 with a more recent version works fine (they are automatically migrated), but the other way around does not.
Comment 10 Cedric Gava CLA 2014-04-29 15:00:07 EDT
Hello Pierre-Charles

I confirm that your sample project works and does not arise the bug. 
I will send you the project that arise the bug tomorrow, mainly to confirm the bug.

Cheers
Cedric
Comment 11 Pierre-Charles David CLA 2014-05-12 04:18:40 EDT
Hi Cedric. Any news on your sample project which triggers the bug?
Comment 12 Cedric Gava CLA 2014-05-14 03:36:09 EDT
Created attachment 243065 [details]
bugging project
Comment 13 Cedric Gava CLA 2014-05-14 04:36:02 EDT
Hello 

Sorry for the delay, I was on holidays :)

way to reproduce :
- import the project in an (empty) workspace
- open the diagram "design-diagram.ecore-entities-top" in the representations.aird file -> everything is OK
- close eclipse
- open it again, and reopen the diagram -> now nothing happens

Do you confirm ?
Comment 14 Pierre-Charles David CLA 2014-05-27 10:00:36 EDT
(In reply to Cedric Gava from comment #13)
> Sorry for the delay, I was on holidays :)

Sorry for the delay too, we're busy preparing for the 1.0.0 release for Luna.

> way to reproduce :
> - import the project in an (empty) workspace
> - open the diagram "design-diagram.ecore-entities-top" in the
> representations.aird file -> everything is OK
> - close eclipse
> - open it again, and reopen the diagram -> now nothing happens
> 
> Do you confirm ?

I tried this using a fresh Luna M6, installing Sirius 1.0.0M6 on it, but I don't reproduce the issue. After closing and restarting Eclipse, I can still open the diagram as I could the first time. Same behavior with Luna M7 + Sirius 1.0M7.

I tried restarting Eclipse with the diagram still opened (instead of closing the diagram, restarting Eclipse, and then manually reopening the diagram): it restarts and opens the diagram fine.

Do you have anything in your error log which could point us into a specific direction?

Also, when you say nothing happens, it means really nothing? Or an empty editor, a loading dialog box which stays forever?
Comment 15 Cedric Gava CLA 2014-05-27 10:31:58 EDT
Do you have anything in your error log which could point us into a specific direction?
>> I put what I got in the Stack trace (https://bugs.eclipse.org/bugs/attachment.cgi?id=242281). I think (but may be wrong) that the issue comes from some other plugins with particular version (have you looked the eclipse install description https://bugs.eclipse.org/bugs/attachment.cgi?id=242282 ?), maybe Acceleo version.

Also, when you say nothing happens, it means really nothing? Or an empty editor, a loading dialog box which stays forever?
>>Sometimes some boxes are drawn, but very far from the original diagram.


Regarding the amount of work you must be charged with the release train date coming soon, and the difficulty to reproduce this bug, I suggest to close this bug, leaving its unconformed status in the history. I too have many things to do, and if this bug appears again, we will be able to link to this ticket.

Agree ?
Comment 16 Pierre-Charles David CLA 2014-05-27 10:40:54 EDT
(In reply to Cedric Gava from comment #15)
> Do you have anything in your error log which could point us into a specific
> direction?
> >> I put what I got in the Stack trace (https://bugs.eclipse.org/bugs/attachment.cgi?id=242281). I think (but may be wrong) that the issue comes from some other plugins with particular version (have you looked the eclipse install description https://bugs.eclipse.org/bugs/attachment.cgi?id=242282 ?), maybe Acceleo version.

Ah, I should have re-read the whole ticket history.

> Regarding the amount of work you must be charged with the release train date
> coming soon, and the difficulty to reproduce this bug, I suggest to close
> this bug, leaving its unconformed status in the history. I too have many
> things to do, and if this bug appears again, we will be able to link to this
> ticket.
> 
> Agree ?

Agreed.