Bug 433377 - "Do you really want to checkout" dialog for branch switching needs a ?
Summary: "Do you really want to checkout" dialog for branch switching needs a ?
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 3.4   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-24 06:13 EDT by Markus Keller CLA
Modified: 2014-05-11 18:35 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (3.31 KB, application/octet-stream)
2014-05-10 18:52 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2014-04-24 06:13:48 EDT 
When I double-click a branch in the Git Repositories view, I get a confirmation dialog with message "Do you really want to checkout '<branchName>'".

The title of the dialog should not be "Confirmation", but the command name that triggered the dialog, e.g.:
=> Checkout Branch

And the message (proper English would use two words "check out" in the verb form, but "man git-checkout" uses both variants):
=> Do you really want to checkout '{{0}}'?

The "Cherry Pick" confirmation dialog looks good.
Comment 1 Tomasz Zarna CLA 2014-05-10 18:52:50 EDT 
Review: https://git.eclipse.org/r/26331
Comment 2 Tomasz Zarna CLA 2014-05-10 18:52:53 EDT 
Created attachment 242936 [details]
mylyn/context/zip
Comment 3 Matthias Sohn CLA 2014-05-11 18:35:55 EDT 
merged as ebc682c454b0a67f458a086aebaa83ae9f33502e