Bug 433348 - Don't decorate empty directories with "untracked" icon (?)
Summary: Don't decorate empty directories with "untracked" icon (?)
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.4   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2014-04-23 20:39 EDT by Born To Code CLA
Modified: 2014-05-12 01:27 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (56.01 KB, application/octet-stream)
2014-05-10 20:00 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Born To Code CLA 2014-04-23 20:39:32 EDT 
We know that Git ignore empty directory. However, Git add icon decoration to an empty directory as if it "can be tracked" (this is my point of view instead of "untracked"). So I have a suggestion not to add that icon decoration, as well as EGit adds no icon decoration to .gitignore'd files.

Thanks
Comment 1 Robin Stocker CLA 2014-04-25 13:50:37 EDT 
You're right, Git CLI also doesn't show empty directories in `git status`. It also doesn't show directories that only contain empty directories.

I've marked the bug as "helpwanted". If anyone wants to implement this, see:

https://wiki.eclipse.org/EGit/Contributor_Guide

See GitLightweightDecorator class, where the decorations are calculated.
Comment 2 Tomasz Zarna CLA 2014-05-10 20:00:28 EDT 
Review: https://git.eclipse.org/r/26333
Comment 3 Tomasz Zarna CLA 2014-05-10 20:00:33 EDT 
Created attachment 242937 [details]
mylyn/context/zip
Comment 4 Matthias Sohn CLA 2014-05-12 01:27:57 EDT 
merged as 33dde12c2b31ed91c9086e24805c84c505833eb6