Bug 433208 - Java Refactoring + SVN: Selecting "Cancel" in resource locking dialog leads to empty error dialog
Summary: Java Refactoring + SVN: Selecting "Cancel" in resource locking dialog leads t...
Status: RESOLVED FIXED
Alias: None
Product: Subversive
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 RC1   Edit
Assignee: Alexander Gurov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-22 10:01 EDT by Michael Becker CLA
Modified: 2014-05-18 16:18 EDT (History)
1 user (show)

See Also:


Attachments
resulting error dialog (8.18 KB, image/png)
2014-04-22 10:02 EDT, Michael Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Becker CLA 2014-04-22 10:01:40 EDT
Actual behavior
===============
If the user performs a Java refactoring that affects Java types that need an SVN lock AND selects "Cancel" in the resulting locking dialogs the refactoring will fail with an empty error dialog (see attached screenshot). I am not sure if this  is a Subversive or a JDT bug. Feel free to move it to the right place if necessary.

Expected behavior
=================
Some useful information in the error dialog, especially:
- WHY the refactoring cannot be performed (a short note about missing locks)
- WHICH FILES are not locked (this is particularly interesting if there are a lot of files from different projects that need to be locked)

Steps to reproduce
==================
- create a Java interface, e.g. "TestInterface"
- create a Java class that implements the interface, e.g. "TestClass"
- add and commit both Java types to SVN repo
- add SVN property "svn:needs-lock" to "TestClass" and commit to SVN repo
- invoke "Refactor -> Rename" on "TestInterface"
- enter a new name
- make sure "Update references" is checked
- click "Next >"
- in the "Lock for selected resources" dialog click "Cancel"
-> see the empty "Found problems" in the resulting error dialog (see attached screenshot)

System details
==============
- Eclipse SDK 4.3.2.M20140221-1700
- Eclipse Java Development Tools 3.9.2.v20140221-1700
- Subversive SVN Team Provider 1.1.3.I20140206-1700
- Subversive SVN Connectors 3.0.5.I20140122-1700
- SVNKit 1.8.3 Implementation 3.0.5.I20140122-1700
- SVN 1.8 + Apache on central server
Comment 1 Michael Becker CLA 2014-04-22 10:02:14 EDT
Created attachment 242191 [details]
resulting error dialog
Comment 2 Alexander Gurov CLA 2014-05-18 16:18:29 EDT
Thank you. It's fixed now.