Bug 43294 - Primary working copy: No updates when changed in working copy mode
Summary: Primary working copy: No updates when changed in working copy mode
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-18 10:17 EDT by Martin Aeschlimann CLA
Modified: 2003-10-14 11:35 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2003-09-18 10:17:08 EDT
20030918

see test cases
 TypeHierarchyTest.testHierarchyWithWorkingCopy1,
 TypeHierarchyTest.testHierarchyWithWorkingCopy2,
 TypeHierarchyTest.testHierarchyWithWorkingCopy3

A hierarchy is created on a type that is then opened in an editor.
The super type is modified, the editor saved: 
The type hierarchy does not send a 'typeHierarchyChanged' notification.

If I understood correctly, the 'typeHierarchyChanged' is supposed to notify only
on save, not while editing the working copy. Crrently it doesn't notify at all.
Comment 1 Jerome Lanneluc CLA 2003-09-23 10:38:00 EDT
v20030918 doesn't exist!

Could you please provide a test case that uses JDT/Core code only?
Comment 2 Martin Aeschlimann CLA 2003-09-23 11:30:22 EDT
Use HEAD of the tests and the test code. the versions denote the jdt.core used, 
or if its a date, the integration build before that date.

I'm afraid I can't rewrite all the test cases to use only jdt.core. Our test 
project has of course dependencies to jdt.ui and we have valuable test util 
classes in out plugin.
It isn't a bad idea to have our test plugins in the workspace anyways.
Comment 3 Philipe Mulet CLA 2003-09-23 12:03:29 EDT
Don't worry we have their last integrated instances. However, when entering a 
defect it isn't a bad idea either to simplify the problem to a test independant 
scenario.

When having to use your HEAD, we usually get into the business of trying to 
figure how many other things we need to update accordingly, and figure when it 
is a good time to update... so we will wait until integration has occurred.
Comment 4 Dirk Baeumer CLA 2003-09-23 12:45:19 EDT
We had this discussion a long time ago with SWT. From the overall performance 
it is more productive to enter a PR without a "component" only test cases. May 
be it takes us an hour to produce the test case and you know in five minutes 
what the problem is. But we are always willing to help to reproduce the 
problem.

Moving back to JDT/Core.
Comment 5 Philipe Mulet CLA 2003-09-23 15:20:39 EDT
Fair enough, but this isn't a 5 minutes operation to get your HEAD contents and 
grab matching prerequisites, then figure out what your test is meant to achieve.

So any early investigation from test owner is guaranteed to speed up 
considerably the fixing process... avoiding to wait for next integration loop.
Comment 6 Jerome Lanneluc CLA 2003-10-01 07:12:08 EDT
Added support to collect changes while the primary working copy is edited, and 
fire a type hierarchy change on commit.
Comment 7 David Audel CLA 2003-10-14 11:35:55 EDT
Verified.