Bug 4328 - should decouple IChange performing from RefactoringWizard (1GLDK52) [refactoring]
Summary: should decouple IChange performing from RefactoringWizard (1GLDK52) [refactor...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dirk Baeumer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 5915
  Show dependency tree
 
Reported: 2001-10-10 23:09 EDT by Dirk Baeumer CLA
Modified: 2004-08-13 11:43 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Baeumer CLA 2001-10-10 23:09:52 EDT 
AK (10/10/2001 11:48:16 AM)
	as it is now, only the RefactoringWizard is knowledgable enough to perform and IChange 
	(that is, send all the correct messages to correct objects, notify the UndoManager and so on)
	
	this function should be removed from the wizard - performing IChange is a more general (and ui-less) thing.
	it should be possible to perfrom IChange and have the undo properly put on the undo stack without having to 
	invoke the wizard or dupicating its code.
	the new class should be a part of the refactoring core.

NOTES:
EG (10.10.2001 21:51:15)
	should be investigated as part of the text infrastructurework
Comment 1 Erich Gamma CLA 2001-12-18 09:47:44 EST 
discussed with Dirk, only solution for now is to duplicate the code
Comment 2 Adam Kiezun CLA 2001-12-19 12:51:29 EST 
done - duplicated code
Comment 3 Adam Kiezun CLA 2002-02-04 11:46:47 EST 
moving to Dirk
Comment 4 Dirk Baeumer CLA 2002-03-11 11:08:20 EST 
We will consider this when we make Refactoring public API. This is post 2.0
Comment 5 Dirk Baeumer CLA 2004-08-13 11:43:16 EDT 
reopening.
Comment 6 Dirk Baeumer CLA 2004-08-13 11:43:38 EDT 
Got addressed for 3.0.