Bug 432672 - Latest test failures caused by new JavaSE/compact profiles
Summary: Latest test failures caused by new JavaSE/compact profiles
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 432780 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-12 10:37 EDT by Thomas Watson CLA
Modified: 2014-04-16 04:35 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2014-04-12 10:37:55 EDT
In bug 432027 I changed org.eclipse.osgi to use Require-Capability for the osgi.ee namespace instead of using a Bundle-RequiredExecutionEnvironment.  I think this has caused the system bundle to be unresolved in the PDE build state. I will see about a fix.
Comment 1 Thomas Watson CLA 2014-04-13 23:23:13 EDT
I am pretty sure I know the reason for the failures, but I am having trouble running the tests from my workspace so I have not been able to confirm.  I will have to spend more time investigating.  For now I have simply commented out the requirement on osgi.ee for the framework.  This is just the work around, but it is pretty safe since the framework will not even load on a < JavaSE-1.6 anyway.  The check for proper osgi.ee at runtime for the running framework is kinda unecessary.
Comment 2 Vikas Chandra CLA 2014-04-15 10:21:43 EDT
*** Bug 432780 has been marked as a duplicate of this bug. ***
Comment 3 Thomas Watson CLA 2014-04-15 13:07:37 EDT
I have a change for review at:

https://git.eclipse.org/r/#/c/25073/

The profile sorting needs to be updated.  Today the JavaSE/compact* profiles are getting sorted above the JavaSE full profiles.  This makes JavaSE/compact3-1.8 the first profile in the list.  In org.eclipse.pde.internal.build.site.PDEState.resolveState() we then default to the first profile if no others are configured.  This used default to JavaSE-1.8 which contains all the necessary JavaSE EEs required to resolve a majority of our bundles.

The fix puts the JavaSE- and J2SE- profiles before the JavaSE/compact profiles.  I think this is the correct thing to do.
Comment 4 Curtis Windatt CLA 2014-04-15 16:31:25 EDT
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=3ed6008e0d23de975203cd313e3d04ca9f23c69b
Pushed the fix to master outside of gerrit

Will leave the bug open to confirm this fixes the tests on all platforms.
Comment 5 Dani Megert CLA 2014-04-16 04:35:11 EDT
The tests pass in N20140415-2000.