431911 – Reconsider test tweaks for JRE 8 compatibility

Bug 431911 - Reconsider test tweaks for JRE 8 compatibility

Summary: Reconsider test tweaks for JRE 8 compatibility

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	Core (show other bugs)
Version:	4.4
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.5 M4
Assignee:	shankha banerjee
QA Contact:

URL:
Whiteboard:
Keywords:	test

Depends on:
Blocks:

Reported:	2014-04-03 09:50 EDT by Stephan Herrmann
Modified:	2014-12-09 10:09 EST (History)
CC List:	5 users (show)

See Also:

Flags:	stephan.herrmann: review+

Attachments
Patch (30.03 KB, patch) 2014-11-26 01:48 EST, shankha banerjee	shankhba: review?	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Stephan Herrmann

2014-04-03 09:50:16 EDT

With the solution in bug 390889 (if that strategy stays) much of the arduous tweak from bug 388800 comment 21 [1] might actually be obsolete now.

I'll use this bug to investigate what can be removed / reverted.

[1] http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?h=BETA_JAVA8&id=dd3bff4d99a5193497eb7e3c0e1bc46a32b7c36a

Comment 1 Srikanth Sankaran

2014-10-12 22:12:36 EDT

Shankha, can you take over this one ? Thanks.

Comment 2 Stephan Herrmann

2014-11-25 10:41:39 EST

hudson seems to be well again, you may want to re-upload your change to gerrit.

Comment 3 shankha banerjee

2014-11-26 01:48:56 EST

Created attachment 248939 [details]
Patch

Hi Stephan,
Could you please review the patch.
All the changes as commit (AbstractRegressionTest.java) described in Comment 0 has been backed out.

Test results are fine. I ran the tests locally.

Thanks

Comment 4 Stephan Herrmann

2014-11-26 18:52:39 EST

I was surprised to see only failing hudson runs, not a final green one.
But anyway, patch looks good. Thanks.

The success here is actually really good news for everybody wanting to compile their Java 7 programs against JRE 8!

Not that I would ever recommend that, btw. ... but ...

Comment 5 shankha banerjee

2014-11-27 01:04:24 EST

Committed the fix: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=6ab08c93576091a47827aa45cdb7ba0e6cb43f77

Comment 6 Jay Arthanareeswaran

2014-12-09 10:09:10 EST

Tests running fine at all compliance levels.

Verified for 4.5 M4 with build I20141208-2000