Bug 431566 - [1.8] Update documentation for null (type) annotations
Summary: [1.8] Update documentation for null (type) annotations
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Doc (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 RC4   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2014-03-29 13:13 EDT by Stephan Herrmann CLA
Modified: 2014-06-07 08:37 EDT (History)
5 users (show)

See Also:


Attachments
First take (25.88 KB, patch)
2014-06-03 07:54 EDT, Stephan Herrmann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2014-03-29 13:13:18 EDT
The documentation from bug 364820 & bug 380074 must be updated to reflect that in 1.8 these are now type annotations.
Also needed:
- migration hints
- documentation of the attribute of @NonNullByDefault

Some of this can be handled by referring to the annotations' javadoc.
Comment 1 Stephan Herrmann CLA 2014-05-13 09:27:24 EDT
See also Bug 434307 comment 18
Comment 2 Stephan Herrmann CLA 2014-06-03 05:04:19 EDT
Shankha, the current help (/org.eclipse.jdt.doc.user/tasks/task-using_null_annotations.htm) shows two screenshots of quickfixes for adding null annotations to the project (heading "Setup of the build path").

Please closely watch if there will be any activity on bug 413583.
Whatever outcome you see on that bug, please prepare a new screenshot
for the plug-in case, which should suggest to add an optional dependency
using Require-Bundle.
Comment 3 Stephan Herrmann CLA 2014-06-03 07:54:15 EDT
Created attachment 243878 [details]
First take

Here's a first take at the new documentation (with minor updates also in the existing section).

Anyone have the time for a quick proof-read & comments?
Comment 4 Stephan Herrmann CLA 2014-06-03 07:55:31 EDT
Naturally, the documentation is best viewed by firing up a runtime workbench, accessing the help documents from a workspace project :)
Comment 5 shankha banerjee CLA 2014-06-03 09:36:21 EDT
I will go through the documentation.

Thanks
Comment 6 Jay Arthanareeswaran CLA 2014-06-03 14:53:20 EDT
(In reply to Stephan Herrmann from comment #3)
> Created attachment 243878 [details]
> First take

Had a quick glance and things look fine overall. There is a lot of details, which will require another round, which I can devote time for perhaps tomorrow. 

Just one question at this point - In null type annotations section (unlike the older null annotations section), the annotations appear as a hyperlinks but don't take my anywhere. Should I be expecting them to work at this point? I see we don't yet have the corresponding APIs added in the doc.isv project.
Comment 7 Stephan Herrmann CLA 2014-06-03 14:59:43 EDT
(In reply to Jayaprakash Arthanareeswaran from comment #6)
> Just one question at this point - In null type annotations section (unlike
> the older null annotations section), the annotations appear as a hyperlinks
> but don't take my anywhere. Should I be expecting them to work at this
> point? I see we don't yet have the corresponding APIs added in the doc.isv
> project.

I think this pb is particular to running a workbench where doc.isv is used from sources. If you use the host's version instead you should see the javadoc.
The full SDK build seems to correctly generate these.
Comment 8 Jay Arthanareeswaran CLA 2014-06-03 15:01:49 EDT
(In reply to Stephan Herrmann from comment #7)
> I think this pb is particular to running a workbench where doc.isv is used
> from sources. If you use the host's version instead you should see the
> javadoc.
> The full SDK build seems to correctly generate these.

I see, thanks for clarifying.
Comment 9 Stephan Herrmann CLA 2014-06-03 16:27:02 EDT
I've pushed my changes / additions via http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=809d40eac5e0fa8ca69b979ad8330296abca5379

Feel free to edit as needed.
Comment 10 Stephan Herrmann CLA 2014-06-03 17:08:13 EDT
Further update regarding the no-longer-recommended quick fix (see bug 413583) released via http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=a24df834b818100666397f4e801a61cf8878161d.
Comment 11 Noopur Gupta CLA 2014-06-04 08:11:58 EDT
In org.eclipse.jdt.doc.user/tasks/task-using_null_type_annotations.htm, I see many hyperlink references to org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/annotation/... for which the files do not exist.

Is that folder yet to be added?
Comment 12 Jay Arthanareeswaran CLA 2014-06-04 08:14:03 EDT
(In reply to Noopur Gupta from comment #11)
> In org.eclipse.jdt.doc.user/tasks/task-using_null_type_annotations.htm, I
> see many hyperlink references to
> org.eclipse.jdt.doc.isv/reference/api/org/eclipse/jdt/annotation/... for
> which the files do not exist.
> 
> Is that folder yet to be added?

Please refer to comment #7. I could verify the links working from the official latest I build.
Comment 13 Noopur Gupta CLA 2014-06-04 09:07:18 EDT
Stephan, thanks for the detailed explanation in the documents. 
It really cleared all the doubts.

Fixed a minor typing issue:  http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=f376800f17b0c7e90dde9c4fe1decb4dccee7282