Bug 431230 - Provide launchers for ppc64le
Summary: Provide launchers for ppc64le
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: Mars   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks: 431232
  Show dependency tree
 
Reported: 2014-03-26 09:51 EDT by Alexander Kurtakov CLA
Modified: 2014-11-12 08:55 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2014-03-26 09:51:55 EDT 
Having fragments and build scripts for building ppc64le(not enabled by default) would be nice. 
If there is agreement that it would be called ppc64le I can start providing patches based on http://rgrunber.fedorapeople.org/0001-Add-support-for-ppc64le.patch . Native build scripts modifications first and fragment after that.
Comment 1 Alexander Kurtakov CLA 2014-04-07 12:20:42 EDT 
Patch: https://git.eclipse.org/r/#/c/24569/
In order to test successfully one needs to create corresponding dir in rt.equinox.binaries but there is no sensible way to add this as git doesn't support empty dirs. Should we have empty file in it for the sake of allowing build?
Comment 2 Thomas Watson CLA 2014-04-09 15:36:29 EDT 
I released the patch with:

http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=ad7c0ec6c65e7a2c843ef2745ffe8ac27deffb45

(In reply to Alexander Kurtakov from comment #1)
> Patch: https://git.eclipse.org/r/#/c/24569/
> In order to test successfully one needs to create corresponding dir in
> rt.equinox.binaries but there is no sensible way to add this as git doesn't
> support empty dirs. Should we have empty file in it for the sake of allowing
> build?

Hmmm, I don't know what the right answer is for this.  If creating a README file to get an "empty" dir helps to make progress I don't see a big issue with doing that.  I guess I will still leave this bug open.  Alexander, close if you think we are done for the purpose of this bug.
Comment 3 Alexander Kurtakov CLA 2014-04-09 16:14:12 EDT 
An idea that came a bit late to me - use maven profiles to enable the module containing the fragment if -Dnative=gtk.linux.ppc64le is passed.
Patch: https://git.eclipse.org/r/#/c/24743/
Comment 4 Thomas Watson CLA 2014-04-09 17:42:14 EDT 
(In reply to Alexander Kurtakov from comment #3)
> An idea that came a bit late to me - use maven profiles to enable the module
> containing the fragment if -Dnative=gtk.linux.ppc64le is passed.
> Patch: https://git.eclipse.org/r/#/c/24743/

Thanks, I think that is a good idea.  I pushed to master:

http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=9a3dee0428c65629c5d35fe7f5d7b36d84fdbae6
Comment 5 Steve Francisco CLA 2014-11-12 08:53:41 EST 
Alex, can this be considered complete based on bug #441358 and bug #442290?
Comment 6 Alexander Kurtakov CLA 2014-11-12 08:55:28 EST 
Yes, resolving it now.