Bug 430974 - [Console Telnet] Addition of a duplicate CommandProcessor in TelnetCommand class
Summary: [Console Telnet] Addition of a duplicate CommandProcessor in TelnetCommand class
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Components (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: equinox.components-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2014-03-24 04:35 EDT by Tomer Pearl CLA
Modified: 2019-09-27 15:11 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomer Pearl CLA 2014-03-24 04:35:57 EDT
When the CommmadProcessor service tracker , in Activaor class, adds a new service, it calls the addCommandProcessor method in the TelnetCommand class.

there, the new CommandProcessor is added twice to the processors list. once, in the addCommandProcessor method, the second, in the telnetServer.addCommandProcessor method.

so, in the end, the processor list contains the same object twice.

a quick fix is to decide in which method to add the new processor, and not in both.

In my opinion, a better solution could be to wrap the processors list in a new class, add or remove processors from that class, and give this new class to both the TelnetCommand and TelnetServer classes.
Comment 1 Thomas Watson CLA 2014-03-24 09:11:51 EDT
A perfect chance to provide a contribution.
Comment 2 Eclipse Genie CLA 2019-09-27 15:11:33 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.