Community
Participate
Working Groups
We as the platform provide a p2f file for newe contributors. Would be nice if they can access the file directly via http from the Git repo: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/plain/releng/org.eclipse.ui.releng/platformUiTools.p2f Currently only the file protocol is supported.
This could be a nice contribution for the hackathon
Affect class: ImportPage from the org.eclipse.equinox.p2.ui.importexport plug-in
I think this method would need to get adjusted: protected void handleDestinationChanged(String newDestination)
See File>Import...>Team Project Set for how they do it, and org.eclipse.team.internal.ui.wizards.ProjectSetImportWizard is the class that implements it. PW
(In reply to Paul Webster from comment #4) > See File>Import...>Team Project Set for how they do it, and > org.eclipse.team.internal.ui.wizards.ProjectSetImportWizard is the class > that implements it. > > PW I think this class delegates to org.eclipse.compare.internal.Utilities.getURLContents, which is internal API. Don't we have a public API in the platform for retrieving the content of a file for a giving URL?
Please use the org.eclipse.equinox.internal.p2.repository.Transport class from p2. This is known to work with proxy, authentication and offers cancellability.
(In reply to Pascal Rapicault from comment #6) > Please use the org.eclipse.equinox.internal.p2.repository.Transport class > from p2. This is known to work with proxy, authentication and offers > cancellability. RepositoryTransport.stream looks good
Added Fix with https://git.eclipse.org/r/#/c/24111/ The UI does not reflect the possibility to use a URL as well. Is this okay? Or expected?
Thanks for you contribution. Make sure to also update the UI because otherwise people won't be able to use the new functionality. I retriggered a build because there were issues with Git clone.
https://hudson.eclipse.org/p2/job/p2-gerrit/202/
I will have a look for the UI. Any hints how to get rid of the line ending stuff in the gerrit change? It might be a little late today but for me it seems like my local line endings are unix style. Although on windows platform. Is there any git magic to configure?
(In reply to Felix Heppner from comment #11) > I will have a look for the UI. > I think a label is sufficient, e.g., enter an URL or select a file via the Browse button.
I see two possibilities for the UI. First is to change the description in the wizzard page from "Install the software mentioned in the description file." to "Enter an URL or select a file via the Browse button." A concatenation of both sentences would be possible but too long imo. Second is to decorate the input with a litte blue "i" Icon and a tool tip with a text similar to that proposed by Lars. This would be the same look as in "Install new software" page where it is possible to type or paste repository urls in the site input / combo box (Work with:). The first one is esay to implement. Simply change the string resource. My first idea was to implement the decoration, for consistency with the other wizzard look. Any preferences for the one or the other possibility or other other ideas?
Pascal has the final say here, but I like option 1.
I tried (easy) first UI tweak and I think this is fine and enough. It actually has been too late yesterday. It seems like the source in repository has windows line endings and my "autocrlf" config in git made it unix style during push. My change now contains the changed string for UI and the source with windows style line endings.
Created attachment 241434 [details] Team Project Set dialog In the Team Project Set dialog, they offer the URL field as a separate box, with a dropdown. Any reason we can't do it the same way (for consistency). PW
We can definitely do it like in the Team Project Set dialog. It is only code. I am not sure if I really like this solution better than the simple one. Consistency is an argument though. Since there is some hierarchy for the import/export page class the explicit choice solution will require a couple of lines of code to implement this "clean". Pascal, any comments from you about the direction to go?
Sorry for the late reply. I lie Paul's request because then it becomes obvious for users that it is now possible to specify a URL.
(In reply to Pascal Rapicault from comment #18) > Sorry for the late reply. I lie Paul's request because then it becomes > obvious for users that it is now possible to specify a URL. Hurry Felix, M7 is going soon (I think next week) and that means feature freeze, AFAIK.
Don't need to stress him Lars :) We have been leaving without this for years so it can wait. M7 is May 5th so we have another 3w.
I started having a look at the UI in "team Project Set" style. I can't promise a solution for this week ... Is there a (written) policy for dependencies? The UI code might be easier and "cleaner" when using jface databinding instead of a couple of listeners at UI events. I will start without databinding and mimic the existing style in ImportPage and Team Project Set code.
(In reply to Felix Heppner from comment #21) > I started having a look at the UI in "team Project Set" style. I can't > promise a solution for this week ... > > Is there a (written) policy for dependencies? The UI code might be easier > and "cleaner" when using jface databinding instead of a couple of listeners > at UI events. I will start without databinding and mimic the existing style > in ImportPage and Team Project Set code. I think runtime components cannot use databinding (higher level component)
(In reply to Lars Vogel from comment #22) > (In reply to Felix Heppner from comment #21) Any update here Felix?
Hm ... I have to admit that this issue went pretty much down in my to do list. Thanks for the reminder. Not much to be done afair. I promise to give it some love soon. Sorry.
Pushed changes to https://git.eclipse.org/r/#/c/24111/12 Jenkins build fail due to a failing test (org.eclipse.equinox.p2.tests.ui.actions.ElementUtilsTest.testUpdateUsingElements see https://hudson.eclipse.org/p2/job/p2-gerrit/287/) most likely not related to my changes. The tests already failed prior to my changes but I hadn't checked it before. The failing test passes in my IDE. I didn't find the time to set up the environment to run the maven build locally.
Adding Stefan, as he showed interest in making the test setup easier via bug 478485.
IMO, the oomph setup scripts make the p2f files irrelevant. They're much easier to use and more powerful. I'd suggest that we delete the p2f scripts and eliminate the extra maintenance burden.
(In reply to Stefan Xenos from comment #27) > IMO, the oomph setup scripts make the p2f files irrelevant. They're much > easier to use and more powerful. I'd suggest that we delete the p2f scripts > and eliminate the extra maintenance burden. This should go to a separate bug for the corresponding project. This bug is about the support for this feature in p2, if we decide not to use it in platform UI that is a different story.
Fair enough. You're right that this feature makes sense independently of what the UI team does with it.
