Bug 430305 - [1.8] Remove the unsupported bytecodes preference in Luna
Summary: [1.8] Remove the unsupported bytecodes preference in Luna
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M7   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-13 12:58 EDT by Curtis Windatt CLA
Modified: 2014-04-30 07:39 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2014-03-13 12:58:24 EDT 
We added a preference setting and problem marker for unsupported bytecodes.  In the Luna stream, the new version of ASM will read Java 8 bytecodes rendering this preference obsolete (until the next Java release).

While there is no harm in having the preference page, it will do nothing.
Comment 1 Vikas Chandra CLA 2014-03-20 06:03:01 EDT 
https://git.eclipse.org/r/#/c/23648/

Curtis, Can you please review this?
Comment 2 Curtis Windatt CLA 2014-03-20 12:14:35 EDT 
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=0e29165218f93175ead7c7c7ef9b41c7d2195354
Reviewed and pushed to master

Mike noted that removing all references to the marker type could end up leaving users with a marker that would never be cleaned.  However, in the master stream there was no way to get an unsupported bytecode marker so 0 users should encounter this.
Comment 3 Vikas Chandra CLA 2014-04-30 07:39:39 EDT 
Verified for Eclipse(4.4) Luna M7 using build eclipse-SDK-I20140429-2000-win32-x86_64