Community
Participate
Working Groups
Our solution for the most-wanted Tycho feature (bug 361722) included adding the attribute "installMode" in product/features/feature elements in product configuration files. We are recommending our users to use the PDE Product Configuration editor for product files, so I wondered if it is possible to add some support for our extension of your product file format in the editor. The absolute minimum would already help: just have the editor leave the attribute unchanged when doing other modifications. If you say that this change is acceptable, we'll probably find someone from the Tycho community to contribute a patch. The background of the Tycho feature is the following: Tycho can create installations/distribution archives from product files. Up to recently, these installations only contained one root element, the product, so it was not possible (or only with advanced p2 magic) to create an installation where the installed features can be updated independently of the product. With Tycho 0.20.0, this has become a lot easier - to see how, try out this demo build: 1. git clone https://git.eclipse.org/r/tycho/org.eclipse.tycho-demo.git 2. git fetch origin refs/changes/59/23059/1 && git checkout FETCH_HEAD 3. Follow the instructions here: https://git.eclipse.org/r/#/c/23059/
If the fix only adds attributes (not additional elements) and is well documented, PDE would be ok with it. It might be tricky to get it working without having UI support for it and I would prefer to keep changes in the UI plug-in minimal. My review time will also be limited, so there is the possibility of a fix not making it in for Luna.
Hi. I currently have a working version of preserving installMode attribute in local workspace. Changes are quite minimal in org.eclipse.pde.internal.core.product.ProductFeature. Can anyone point me to how can I submit a patch? Pull request?
A gerrit change is the easiest to review and merge, but attaching a diff patch to this bug would be fine. PDE does have a contribution guide, but the Platform UI version is much more detailed and helpful. https://wiki.eclipse.org/Platform_UI/How_to_Contribute A github pull request isn't optimal as the github repo is a mirror of the one hosted at eclipse.org.
(In reply to Curtis Windatt from comment #3) > A gerrit change is the easiest to review and merge, but attaching a diff > patch to this bug would be fine. PDE does have a contribution guide, but > the Platform UI version is much more detailed and helpful. > https://wiki.eclipse.org/Platform_UI/How_to_Contribute > > A github pull request isn't optimal as the github repo is a mirror of the > one hosted at eclipse.org. For an introduction into contributing with Gerrit to Eclipse see also: http://www.vogella.com/tutorials/Gerrit/article.html#eclipsegerritcontribution
Thanks Lars, most topics link to that anyway. Ok, I pushed to gerrit: https://git.eclipse.org/r/23143
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=7824c9b20a52a381d042aa01608724084a2bafe7 Fix applied to master I will fix the copyrights in a separate commit.
@Anton: Thank you for the contribution. @Curtis: Thank you for reviewing the contribution. This is great: With Luna M7, the forms-based editor for product files can again be recommended for Tycho without limitations (see also the Tycho documentation here [1]). [1] https://wiki.eclipse.org/Tycho/eclipse-repository#Source_files
