Bug 429792 - JavaFX - AUT does not terminate / disappear from running AUTs view if OMM has been used
Summary: JavaFX - AUT does not terminate / disappear from running AUTs view if OMM has...
Status: CLOSED FIXED
Alias: None
Product: Jubula (Archived)
Classification: Technology
Component: RC (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 critical (vote)
Target Milestone: 2.3   Edit
Assignee: Zeb Ford-Reitz CLA
QA Contact: Oliver Goetz CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 428996
  Show dependency tree
 
Reported: 2014-03-06 10:45 EST by Markus Tiede CLA
Modified: 2014-03-25 07:03 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Tiede CLA 2014-03-06 10:45:41 EST
Its seems as if the AUT does not terminate / disappear from running AUTs view if the OMM has been used / once been active. Stopping the AUT via the toolbar item does seem to work - manually terminating it e.g. via clicking the [x] not. This is easily reproducible e.g. using the SimpleAdder (FX) AUT.
Comment 1 Achim Loerke CLA 2014-03-06 11:14:21 EST
Should be fixed before the standalone release if it seems reasonable risk free.
Comment 2 Zeb Ford-Reitz CLA 2014-03-12 05:32:09 EDT
It looks like the problem originates in the constructor for o.e.j.rc.javafx.listener.MouseMoveDone:
 * An ExecutorService is instantiated without explicitly specifying a ThreadFactory.
 * The default ThreadFactory implementation ensures that created Threads will *not* be daemons.
 * The Executor Thread remains running even after the AUT is ended.

It would also be worth looking into whether the ExecutorService should be shut down when Object Mapping Mode (and other modes in which it is used, if any) is ended.
Comment 3 Zeb Ford-Reitz CLA 2014-03-20 11:07:26 EDT
Fixed with:
http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=00c0a7be940e44fde6fceb788b27bc0c62d10f89

I opted for the daemon thread route beacuse:
 * the worker threads aren't doing anything that requires that they shut down cleanly, and
 * the logic for when to start and stop the Executor is not *blatantly* obvious to me.
Comment 4 Maissmaallsmyss Maulhs-Vvuillss CLA 2014-03-21 12:53:34 EDT
I´ve tested this with CaA-JavaFX AUT Configuration an Windows 7, on gandalf and  on Mac, manually terminating after using the OMM works fine.
Comment 5 Oliver Goetz CLA 2014-03-25 07:03:31 EDT
Closed due to comment 4.