Bug 428417 - [Tests] HcrTests.testHCRAnonymousType3
Summary: [Tests] HcrTests.testHCRAnonymousType3
Status: REOPENED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: test
: 454855 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-18 07:00 EST by Dani Megert CLA
Modified: 2023-01-30 17:13 EST (History)
5 users (show)

See Also:
daniel_megert: pmc_approved+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2014-02-18 07:00:07 EST
N20140217-2000.

http://download.eclipse.org/eclipse/downloads/drops4/N20140217-2000/testresults/html/org.eclipse.jdt.debug.tests_win32.win32.x86_7.0.html

Listener should have been notified

junit.framework.AssertionFailedError: Listener should have been notified
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRAnonymousType3(HcrTests.java:593)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2405)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:55)
at java.lang.Thread.run(Thread.java:722)
Comment 1 Sarika Sinha CLA 2015-03-10 06:40:34 EDT
Similar test fails
http://download.eclipse.org/eclipse/downloads/drops4/N20150309-2000/testresults/html/org.eclipse.jdt.debug.tests_win32.win32.x86_7.0.html
testHCRLocalType3	Failure	Listener should have been notified

junit.framework.AssertionFailedError: Listener should have been notified
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRLocalType3(HcrTests.java:435)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2464)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:55)
at java.lang.Thread.run(Thread.java:744)
Comment 2 Sarika Sinha CLA 2015-07-22 00:05:11 EDT
*** Bug 454855 has been marked as a duplicate of this bug. ***
Comment 3 Sarika Sinha CLA 2015-07-22 00:07:32 EDT
Failed again
http://download.eclipse.org/eclipse/downloads/drops4/I20150721-0800/testresults/html/org.eclipse.jdt.debug.tests_win32.win32.x86_7.0.html

testHCRAnonymousType3	Error	N/A

java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:859)
at java.util.ArrayList$Itr.next(ArrayList.java:831)
at org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.removeAnnotations(AbstractMarkerAnnotationModel.java:398)
at org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.updateMarkers(AbstractMarkerAnnotationModel.java:640)
at org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.commit(AbstractMarkerAnnotationModel.java:697)
at org.eclipse.core.internal.filebuffers.ResourceTextFileBuffer.commitFileBufferContent(ResourceTextFileBuffer.java:409)
at org.eclipse.core.internal.filebuffers.ResourceFileBuffer.commit(ResourceFileBuffer.java:327)
at org.eclipse.jdt.internal.ui.javaeditor.DocumentAdapter.save(DocumentAdapter.java:513)
at org.eclipse.jdt.internal.core.CommitWorkingCopyOperation.executeOperation(CommitWorkingCopyOperation.java:123)
at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:729)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:794)
at org.eclipse.jdt.internal.core.CompilationUnit.commitWorkingCopy(CompilationUnit.java:391)
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRAnonymousType3(HcrTests.java:594)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2466)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:57)
at java.lang.Thread.run(Thread.java:744)
Comment 12 pasam soujanya CLA 2016-09-08 02:51:01 EDT
This issue is seen with IBM SDK with the below version.
java version "1.7.0"
Java(TM) SE Runtime Environment (build pxi3270_27sr4-20160907_01(SR4))
IBM J9 VM (build 2.7, JRE 1.7.0 Linux x86-32 20160906_317630 (JIT enabled, AOT enabled)
J9VM - R27_jvm.27_20160906_0002_B317630
JIT  - tr.r13.java_20160823_123277
GC   - R27_jvm.27_20160906_0002_B317630
J9CL - 20160906_317630)

Error Trace:
--------------------
ECL (eclipse) java.util.ConcurrentModificationException
ECL 	at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:871)
ECL 	at java.util.ArrayList$Itr.next(ArrayList.java:843)
ECL 	at org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.removeAnnotations(AbstractMarkerAnnotationModel.java:398)
ECL 	at org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.updateMarkers(AbstractMarkerAnnotationModel.java:640)
ECL 	at org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.commit(AbstractMarkerAnnotationModel.java:697)
ECL 	at org.eclipse.core.internal.filebuffers.ResourceTextFileBuffer.commitFileBufferContent(ResourceTextFileBuffer.java:409)
ECL 	at org.eclipse.core.internal.filebuffers.ResourceFileBuffer.commit(ResourceFileBuffer.java:327)
ECL 	at org.eclipse.jdt.internal.ui.javaeditor.DocumentAdapter.save(DocumentAdapter.java:472)
ECL 	at org.eclipse.jdt.internal.core.CommitWorkingCopyOperation.executeOperation(CommitWorkingCopyOperation.java:123)
ECL 	at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:729)
ECL 	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2241)
ECL 	at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:794)
ECL 	at org.eclipse.jdt.internal.core.CompilationUnit.commitWorkingCopy(CompilationUnit.java:391)
ECL 	at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRLocalType3(HcrTests.java:435)
ECL 	at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2466)
ECL 	at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:57)
ECL 	at java.lang.Thread.run(Thread.java:809)
Comment 13 Andrey Loskutov CLA 2016-09-09 07:14:24 EDT
Just wondering if this bug belongs to the Platform Text component?
The problem is that access to org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.fDeletedAnnotations is not thread safe, so that this list can be modified and iterated at same time => causing the ConcurrentModificationException.
Comment 14 Eclipse Genie CLA 2016-09-09 07:38:22 EDT
New Gerrit change created: https://git.eclipse.org/r/80782
Comment 16 Sarika Sinha CLA 2016-09-20 02:30:26 EDT
(In reply to Andrey Loskutov from comment #13)
> Just wondering if this bug belongs to the Platform Text component?
> The problem is that access to
> org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.fDeletedAnnotations
> is not thread safe, so that this list can be modified and iterated at same
> time => causing the ConcurrentModificationException.

Very much probable, Can you push that fix ? We get this error minimum 3 times every month so we will have the results very soon.
Comment 18 Andrey Loskutov CLA 2016-09-20 03:28:37 EDT
(In reply to Sarika Sinha from comment #16)
> (In reply to Andrey Loskutov from comment #13)
> > Just wondering if this bug belongs to the Platform Text component?
> > The problem is that access to
> > org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel.fDeletedAnnotations
> > is not thread safe, so that this list can be modified and iterated at same
> > time => causing the ConcurrentModificationException.
> 
> Very much probable, Can you push that fix ? We get this error minimum 3
> times every month so we will have the results very soon.

I've merged the change now. Next nightly build should have it in.
Comment 19 Andrey Loskutov CLA 2016-09-20 03:32:52 EDT
I'm assigning this to me now and set version to 4.6.2: in case the fix works for jdt, it makes sense to backport it.

@Sarika: since I'm not monitoring jdt tests state, can you please ping me if the fix will not work?
Comment 20 Sarika Sinha CLA 2016-09-20 05:29:09 EDT
(In reply to Andrey Loskutov from comment #19)
> I'm assigning this to me now and set version to 4.6.2: in case the fix works
> for jdt, it makes sense to backport it.
> 
> @Sarika: since I'm not monitoring jdt tests state, can you please ping me if
> the fix will not work?

Thanks, Will keep you updated.
Comment 21 Sarika Sinha CLA 2016-10-06 04:22:05 EDT
We got it failed on 4.6.2 build. Didn't see it failing on 4.7 after the fix.

http://download.eclipse.org/eclipse/downloads/drops4/M20161005-1200/testresults/html/org.eclipse.jdt.debug.tests_ep46M-unit-win32_win32.win32.x86_8.0.html
Comment 22 Andrey Loskutov CLA 2016-11-06 07:02:13 EST
(In reply to Sarika Sinha from comment #21)
> We got it failed on 4.6.2 build. Didn't see it failing on 4.7 after the fix.
> 
> http://download.eclipse.org/eclipse/downloads/drops4/M20161005-1200/
> testresults/html/org.eclipse.jdt.debug.tests_ep46M-unit-win32_win32.win32.
> x86_8.0.html

I will also backport it to 4.6, see https://git.eclipse.org/r/84529/

@Dani: can you please +1?
Comment 23 Eclipse Genie CLA 2016-11-07 09:54:57 EST
New Gerrit change created: https://git.eclipse.org/r/84529
Comment 25 Sarika Sinha CLA 2016-11-13 22:48:33 EST
Can't mark it Verified so early, will monitor if it fails or not in further M builds.
Comment 26 Sarika Sinha CLA 2016-11-14 22:27:50 EST
http://download.eclipse.org/eclipse/downloads/drops4/I20161110-2030/testresults/html/org.eclipse.jdt.debug.tests_ep47I-unit-win32_win32.win32.x86_8.0.html

testHCRInnerType3	Failure	Listener should have been notified

junit.framework.AssertionFailedError: Listener should have been notified
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRInnerType3(HcrTests.java:867)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2470)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:57)
at java.lang.Thread.run(Thread.java:745)
	45.688
testHCRInnerType4	Failure	We should be stopped in the run method expected:<[run]> but was:<[<init>]>

junit.framework.ComparisonFailure: We should be stopped in the run method expected:<[run]> but was:<[<init>]>
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRInnerType4(HcrTests.java:928)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2470)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:57)
at java.lang.Thread.run(Thread.java:745)
	1.985
testHCRInnerType5	Failure	We should be stopped in the outerrun method expected:<[outerrun]> but was:<[<init>]>

junit.framework.ComparisonFailure: We should be stopped in the outerrun method expected:<[outerrun]> but was:<[<init>]>
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRInnerType5(HcrTests.java:984)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2470)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:57)
at java.lang.Thread.run(Thread.java:745)
Comment 27 Andrey Loskutov CLA 2016-11-17 09:56:24 EST
The original error is gone, but now we have "Listener should have been notified" assertion.
Comment 28 Sarika Sinha CLA 2016-11-30 22:01:49 EST
Moving to M5.
Comment 29 Sarika Sinha CLA 2017-01-18 23:25:59 EST
testHCRAnonymousType3	Failure	Listener should have been notified

junit.framework.AssertionFailedError: Listener should have been notified
at org.eclipse.jdt.debug.tests.core.HcrTests.testHCRAnonymousType3(HcrTests.java:597)
at org.eclipse.jdt.debug.tests.AbstractDebugTest.runBare(AbstractDebugTest.java:2469)
at org.eclipse.jdt.debug.tests.DebugSuite$1.run(DebugSuite.java:57)
at java.lang.Thread.run(Thread.java:745)

http://download.eclipse.org/eclipse/downloads/drops4/M20170118-0830/testresults/html/org.eclipse.jdt.debug.tests_ep46M-unit-win32_win32.win32.x86_8.0.html
Comment 30 Sarika Sinha CLA 2017-01-19 01:43:41 EST
@Andrey,
Are you working or planning to work on this ?
Comment 31 Andrey Loskutov CLA 2017-01-19 01:50:13 EST
(In reply to Sarika Sinha from comment #30)
> @Andrey,
> Are you working or planning to work on this ?

No.
Comment 32 Sarika Sinha CLA 2017-01-19 03:45:33 EST
Moving out of M5, as no one is working on this currently.
Comment 33 Sarika Sinha CLA 2017-05-19 02:05:38 EDT
Not seeing it failing recently.
Comment 37 Eclipse Genie CLA 2020-08-03 15:21:33 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 38 Eclipse Genie CLA 2023-01-30 17:13:04 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.