427799 – Provide a cleaner, more efficient implementation of the Session API

Bug 427799 - Provide a cleaner, more efficient implementation of the Session API

Summary: Provide a cleaner, more efficient implementation of the Session API

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Core (show other bugs)
Version:	1.0.0M5
Hardware:	All All

Importance:	P1 major (vote)
Target Milestone:	3.0.0M7
Assignee:	Pierre-Charles David
QA Contact:	Laurent Redor

URL:
Whiteboard:
Keywords:	triaged

Depends on:	426811 427813
Blocks:
	Show dependency tree

Reported:	2014-02-10 09:17 EST by Pierre-Charles David
Modified:	2015-06-24 11:13 EDT (History)
CC List:	6 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pierre-Charles David

2014-02-10 09:17:54 EST

The Session concept is central in the Sirius runtime, but its API and implementation have become complex, difficult to maintain and to optimize.

More specifically, the current implementation (DAnalysisSessionImpl and associated classes) tries to support different modes of behaviors, some of which impose a lot of complexity and runtime overhead even when they are not needed (which is most of the time, for most users).

This ticket will be used to discuss a general strategy and concrete actions towards the replacement of the current implementation with a new, more efficient one which does not try to handle all the "legacy" uses cases. This will be done over several versions of Sirius, so that we can keep the existing implementation as long as needed for compatibility for existing users.

The proposed general strategy:
1. Make it technically possible to have several implementations of the Session API in the code, selectable at runtime. Note that the session's contract itself might need to evolve, so we are not necessarily talking about a single set of Java interfaces which can be implemented in several ways; it might be necessary to have two sets of APIs ("Old-Style Sessions" and "New-Style Session") co-exist peacefully.
2. Provide a new implementation of the session concepts and APIs with better properties than the current one, but make the new implementation opt-in (i.e. client code will need to ask explicitly to use the new version).
3. Once we are confident enough that the new implementation is complete and stable, make the new one the default. The old one would still be available if explicitly requested, but it would become deprecated.
4. Remove the old implementation altogether once we are sure all users have migrated to the new one.

Comment 1 Pierre-Charles David

2014-02-10 09:48:17 EST

I have created https://wiki.eclipse.org/Sirius/Session_API to complement this ticket.

Comment 2 Maxime Porhel

2014-02-10 10:34:23 EST

Pierre-Charles some related elements: Bug 426811 and https://git.eclipse.org/r/#/c/21509/

Comment 3 Eclipse Genie

2015-02-25 11:21:04 EST

New Gerrit change created: https://git.eclipse.org/r/42663

Comment 4 Eclipse Genie

2015-02-25 11:21:06 EST

New Gerrit change created: https://git.eclipse.org/r/42666

Comment 5 Eclipse Genie

2015-02-25 11:21:08 EST

New Gerrit change created: https://git.eclipse.org/r/42665

Comment 6 Eclipse Genie

2015-02-25 11:21:09 EST

New Gerrit change created: https://git.eclipse.org/r/42664

Comment 7 Eclipse Genie

2015-02-25 11:21:11 EST

New Gerrit change created: https://git.eclipse.org/r/42669

Comment 8 Eclipse Genie

2015-02-25 11:21:12 EST

New Gerrit change created: https://git.eclipse.org/r/42668

Comment 9 Eclipse Genie

2015-02-25 11:21:14 EST

New Gerrit change created: https://git.eclipse.org/r/42667

Comment 10 Eclipse Genie

2015-02-25 11:21:15 EST

New Gerrit change created: https://git.eclipse.org/r/42671

Comment 11 Eclipse Genie

2015-02-25 11:21:17 EST

New Gerrit change created: https://git.eclipse.org/r/42670

Comment 12 Eclipse Genie

2015-02-25 15:46:24 EST

Gerrit change https://git.eclipse.org/r/39390 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=845edd6a36e61ff518ed2462a7726404d5577280

Comment 13 Eclipse Genie

2015-02-25 15:46:36 EST

Gerrit change https://git.eclipse.org/r/42663 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1fb9718ebf64ccf3c3054a03062f304e7ffbb3ff

Comment 14 Eclipse Genie

2015-02-26 10:56:47 EST

Gerrit change https://git.eclipse.org/r/42671 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8a5ceae32a9a2414cf1a48a01ba98107b8406a66

Comment 15 Eclipse Genie

2015-02-26 10:56:51 EST

Gerrit change https://git.eclipse.org/r/42670 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=86812009da49387db0369d38027cb64da2caf945

Comment 16 Eclipse Genie

2015-02-26 10:56:54 EST

Gerrit change https://git.eclipse.org/r/42669 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3959a8ffee6fdc020a2c6c2b1a4aef28c46b7fd9

Comment 17 Eclipse Genie

2015-02-26 10:56:57 EST

Gerrit change https://git.eclipse.org/r/42668 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bd72d57c92608a07b09de2f7bc1f8d9c485f3eff

Comment 18 Eclipse Genie

2015-02-26 10:57:00 EST

Gerrit change https://git.eclipse.org/r/42667 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d4c29bfab31190bf964cb1cad80145b5eb642272

Comment 19 Eclipse Genie

2015-02-26 10:57:01 EST

Gerrit change https://git.eclipse.org/r/42665 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5970079c39e32a9a573ab4e602811be949b7b060

Comment 20 Eclipse Genie

2015-02-26 10:57:04 EST

Gerrit change https://git.eclipse.org/r/42666 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4ddb8ab3b4f3ae033782fc811890d9ebc707bdbf

Comment 21 Eclipse Genie

2015-02-26 10:57:06 EST

Gerrit change https://git.eclipse.org/r/42664 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=30351957d9dabe7db92e1d09c2b6d064b9c1e888

Comment 22 Eclipse Genie

2015-02-27 03:08:27 EST

New Gerrit change created: https://git.eclipse.org/r/42871

Comment 23 Eclipse Genie

2015-02-27 04:25:58 EST

Gerrit change https://git.eclipse.org/r/42871 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6b2acf6332937982542bc1dd18c0d7551b8c42b2

Comment 24 Eclipse Genie

2015-04-09 09:16:29 EDT

New Gerrit change created: https://git.eclipse.org/r/45547

Comment 25 Eclipse Genie

2015-04-09 09:16:42 EDT

New Gerrit change created: https://git.eclipse.org/r/45548

Comment 26 Eclipse Genie

2015-04-09 09:16:44 EDT

New Gerrit change created: https://git.eclipse.org/r/45549

Comment 27 Eclipse Genie

2015-04-10 11:17:45 EDT

New Gerrit change created: https://git.eclipse.org/r/45653

Comment 28 Eclipse Genie

2015-04-10 11:17:48 EDT

New Gerrit change created: https://git.eclipse.org/r/45652

Comment 29 Eclipse Genie

2015-04-10 11:17:49 EDT

New Gerrit change created: https://git.eclipse.org/r/45656

Comment 30 Eclipse Genie

2015-04-10 11:17:51 EDT

New Gerrit change created: https://git.eclipse.org/r/45655

Comment 31 Eclipse Genie

2015-04-10 11:17:52 EDT

New Gerrit change created: https://git.eclipse.org/r/45654

Comment 32 Eclipse Genie

2015-04-10 11:17:54 EDT

New Gerrit change created: https://git.eclipse.org/r/45658

Comment 33 Eclipse Genie

2015-04-10 11:17:55 EDT

New Gerrit change created: https://git.eclipse.org/r/45657

Comment 34 Eclipse Genie

2015-04-10 11:17:57 EDT

New Gerrit change created: https://git.eclipse.org/r/45661

Comment 35 Eclipse Genie

2015-04-10 11:17:58 EDT

New Gerrit change created: https://git.eclipse.org/r/45660

Comment 36 Eclipse Genie

2015-04-10 11:18:00 EDT

New Gerrit change created: https://git.eclipse.org/r/45659

Comment 37 Eclipse Genie

2015-04-10 11:18:01 EDT

New Gerrit change created: https://git.eclipse.org/r/45663

Comment 38 Eclipse Genie

2015-04-10 11:18:03 EDT

New Gerrit change created: https://git.eclipse.org/r/45662

Comment 39 Eclipse Genie

2015-04-14 03:42:55 EDT

Gerrit change https://git.eclipse.org/r/45549 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=81365a83b09b4de7932f66ef7f699efddabde406

Comment 40 Eclipse Genie

2015-04-14 03:43:00 EDT

Gerrit change https://git.eclipse.org/r/45548 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4bdbf3a79d68eda77b1ec6a2f5b2f5db6899b64f

Comment 41 Eclipse Genie

2015-04-14 03:43:02 EDT

Gerrit change https://git.eclipse.org/r/45547 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=73b60c34fa3e15213e3f5b379db6dd6c75d7b703

Comment 42 Eclipse Genie

2015-04-14 05:03:58 EDT

Gerrit change https://git.eclipse.org/r/45652 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=80a20d8b3eaa47fc47eb5d3bbc39f528c50fc507

Comment 43 Eclipse Genie

2015-04-14 05:11:31 EDT

Gerrit change https://git.eclipse.org/r/45653 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9f743fbf2224fd239afb4df7291343cd56823639

Comment 44 Eclipse Genie

2015-04-14 05:51:38 EDT

Gerrit change https://git.eclipse.org/r/45654 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3422b6409745ef283d997a08ab566d880c7dd3f6

Comment 45 Eclipse Genie

2015-04-15 10:06:32 EDT

Gerrit change https://git.eclipse.org/r/45663 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a78ecdb99eda0941731b41bb32f7c8dc6a6737e4

Comment 46 Eclipse Genie

2015-04-15 10:06:36 EDT

Gerrit change https://git.eclipse.org/r/45662 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=440ac80e04a5308dc4dc2b38aeb2d440ab746a12

Comment 47 Eclipse Genie

2015-04-15 10:06:38 EDT

Gerrit change https://git.eclipse.org/r/45661 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fa60b94f8c147e6e49d4e98232dcaed77fce847a

Comment 48 Eclipse Genie

2015-04-15 10:06:51 EDT

Gerrit change https://git.eclipse.org/r/45660 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b2f7ce15b82798e853d690941b068484ccd3b439

Comment 49 Eclipse Genie

2015-04-15 10:06:53 EDT

Gerrit change https://git.eclipse.org/r/45659 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c6b053356950571d8b6e2135dd570b4a2f7e1946

Comment 50 Eclipse Genie

2015-04-15 10:06:56 EDT

Gerrit change https://git.eclipse.org/r/45658 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b8ea76178b86b927dea25dc1a0334f6b040f9582

Comment 51 Eclipse Genie

2015-04-15 10:07:00 EDT

Gerrit change https://git.eclipse.org/r/45657 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fda3222a7d0272bdc4e6e834f20bc59f7afa3182

Comment 52 Eclipse Genie

2015-04-15 10:07:03 EDT

Gerrit change https://git.eclipse.org/r/45656 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=18e09ec89df3cf90b876255bcdde3a60bf6fdb33

Comment 53 Eclipse Genie

2015-04-15 10:07:05 EDT

Gerrit change https://git.eclipse.org/r/45655 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=2bb9d20791fc08edf37b79ae2a7ab4ebd1b0e96b

Comment 54 Eclipse Genie

2015-04-20 10:53:42 EDT

New Gerrit change created: https://git.eclipse.org/r/46080

Comment 55 Eclipse Genie

2015-04-20 10:53:45 EDT

New Gerrit change created: https://git.eclipse.org/r/46079

Comment 56 Eclipse Genie

2015-04-20 10:53:46 EDT

New Gerrit change created: https://git.eclipse.org/r/46078

Comment 57 Eclipse Genie

2015-04-20 10:53:48 EDT

New Gerrit change created: https://git.eclipse.org/r/46082

Comment 58 Eclipse Genie

2015-04-20 10:53:50 EDT

New Gerrit change created: https://git.eclipse.org/r/46081

Comment 59 Eclipse Genie

2015-04-20 10:53:51 EDT

New Gerrit change created: https://git.eclipse.org/r/46084

Comment 60 Eclipse Genie

2015-04-20 10:53:53 EDT

New Gerrit change created: https://git.eclipse.org/r/46083

Comment 61 Eclipse Genie

2015-04-20 10:53:54 EDT

New Gerrit change created: https://git.eclipse.org/r/46085

Comment 62 Eclipse Genie

2015-04-21 02:15:57 EDT

Gerrit change https://git.eclipse.org/r/46085 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1d40ce1dab61537a8fe78a79e99c4de0eea4dcc8

Comment 63 Eclipse Genie

2015-04-21 02:16:01 EDT

Gerrit change https://git.eclipse.org/r/46084 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8d8027e576706bb8684cf28faa487fc7b08bdd3f

Comment 64 Eclipse Genie

2015-04-21 02:16:03 EDT

Gerrit change https://git.eclipse.org/r/46083 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3522a3368fcf31b605eba3561a63477ff9bf03a1

Comment 65 Eclipse Genie

2015-04-21 02:16:06 EDT

Gerrit change https://git.eclipse.org/r/46082 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4ea7a66900ba14facd5f6a2ffcecde0aba4d9531

Comment 66 Eclipse Genie

2015-04-21 02:16:11 EDT

Gerrit change https://git.eclipse.org/r/46081 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7bd37e9d8e3fa582a99231dec9d3946327751a04

Comment 67 Eclipse Genie

2015-04-21 02:16:12 EDT

Gerrit change https://git.eclipse.org/r/46080 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b4e6e96b74f2685cc8755daa472131c543603c93

Comment 68 Eclipse Genie

2015-04-21 02:16:15 EDT

Gerrit change https://git.eclipse.org/r/46079 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fc45c0224943725e31d8b5ce611999df763b8ecf

Comment 69 Eclipse Genie

2015-04-21 02:16:18 EDT

Gerrit change https://git.eclipse.org/r/46078 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=46c3fc0f55a18d72523a448eb77fef5f02f55d67

Comment 70 Pierre-Charles David

2015-04-21 03:24:10 EDT

Closing for 3.0. There are many other potential improvements in this area, but in the context of Sirius 3.0 we'll stop here for general refactoring. Other improvements may still come from work on more specific issues.

Comment 71 Laurent Redor

2015-05-21 09:54:39 EDT

Verified with Sirius 3.0.0 rc1

Comment 72 Pierre-Charles David

2015-06-24 11:13:44 EDT

Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.