Community
Participate
Working Groups
As mentioned in http://stackoverflow.com/questions/21482918/auto-generate-variable-for-return-value-of-method I miss a content proposal method to have the return value of a method as delivered by content proposal do a direct assignment to a variable. That is (see above example) sps.[CTRL+SPACE] should allow for a single selection to return me the respective getter method and a variable assignment. So instead of having to sps.[CTRL+SPACE] --> select getChildren [ENTER] sps.getChildren() [CTRL+2]+L List<foo> = sps.getChildren() a one presser would be nice. Like sps.[CTRL+SPACE] --> select getChildren [CTRL+ENTER] I think this would be more intuitive than the way over quick fix.
> I think this would be more intuitive than the way over quick fix. I don't think it's intuitive that one knows, Ctrl+Enter directly assigns to a variable and it's definitely not discoverable. There are no plans to overload content assist in such a way.
Created attachment 239846 [details] embedding place Well, if it would be mentioned in the botton line (see image) then I guess it would be obvious. What do you mean by "there are no plans"? That, you are not considering this, that you think it is unnecessary, ... if so, please resolve as WONTFIX thanks
As you see in your picture, that space is already used. Showing two hints would overload the status line.
Realising it like the postfix feature in IntelliJ (see http://blog.jetbrains.com/idea/2014/03/postfix-completion/) would be a very good approach!
(In reply to Marco Descher from comment #4) > Realising it like the postfix feature in IntelliJ (see > http://blog.jetbrains.com/idea/2014/03/postfix-completion/) would be a very > good approach! That would turn your request into two distinct completion proposal. I.e. one for "getChildren()" and one for "assign to new local variable". Which makes more sense to me. We should investigate (maybe just work a bit with intellij) how cool this feature really is in practice. Also generally in template proposals it would be cool, to have access to the receiver expression, such that you can surround it with text rather than just appending text.
(In reply to Sven Efftinge from comment #5) > (In reply to Marco Descher from comment #4) > > Realising it like the postfix feature in IntelliJ (see > > http://blog.jetbrains.com/idea/2014/03/postfix-completion/) would be a very > > good approach! > > That would turn your request into two distinct completion proposal. I.e. one > for "getChildren()" and one for "assign to new local variable". Which makes > more sense to me. We should investigate (maybe just work a bit with > intellij) how cool this feature really is in practice. Also generally in > template proposals it would be cool, to have access to the receiver > expression, such that you can surround it with text rather than just > appending text. Resolving it could work like sps.[CTRL+SPACE; select getChildren()].[CTRL+SPACE; select assignToNewLocalVariable] Would it be possible to add scripting capability here? So one could write a script named "assignToNewLocalVariable" which just executes the aforementioned [CTRL+2]+L at this place and is presented in the content proposal?!
One option might be to change Content Assist popup so that instead of eating a shortcut key combination it doesn't recognize it could treat it like a confirmation, perform the change and after that pass the original shortcut key to the underlying editor to be handled. So you could have 'Assign to new local variable' command bound to Ctrl+; and could press that instead of Enter to confirm the selected item.
I agree with Dani, that [CTRL+ENTER] is hard to discover and it is is more or less the same as [CTRL+2]+L. But I really like the idea of using [CTRL+ENTER] to propose also a variable assignment. Dani, would that fit in the JDT architecture? I think such a functionality could also be used to implement PostFix completion similar to IntelliJ.
I've pushed a patch to Gerrit for bug 428139 which among other things adds a key binding Ctrl-Alt-Left Arrow for extracting new local variable from an expression or a method call, like you would have after using Content Assist. It may provide another way of satisfying some of the use-cases in this bug. Please try it out to see if it works for you.
