Community
Participate
Working Groups
I20140130-1400 - press Ctrl+Shift+F to bring up the Find File dialog - type 'built-' (no quotes) in its text field --> the dialog shows three possible matches - press 'b' (no quotes) and wait; the dialog flashes as it shrinks-and-grows to show its updated list of matches, but the list didn't change - repeat with the subsequent letters: r, o, w, etc. and note that it happens every time - this shrink-and-grow flash ideally should not happen even if the list of matches is growing/shrinking (presumably it can be more smooth than it currently is?) - it definitely seems like it should not happen when the list does not change
Still happens in the latest, just note that the test string is now built-commitBrowser.
I'll make this match with the new header search UI.
Silenio and I have just had a talk about this and the conclusion was that the right answer to this defect is to remove both this and the QuickSearch dialogs and instead use the existing 'Global Search' side panel for all search operations... For file searches we expect to hide the fields used to constrain the global search using a file pattern and just change the prompt for the main search field to 'type a file name'. This has many advantages beyond code re-use and solving this defect. The search results are remembered so that you can just click on a different file if the one you clicked on isn't the one you wanted. There's also existing code to maintain an MRU of previous searches (we may want to have two lists; one for content searches and a different one for file searches). Steve, what do you think about this approach. (we'll also fix the CSS to match the rest of the UI ('gray is passe').
+1 for the single dialog I'm not 100% sure about the "file searches" idea. In my mind, searching the contents of various files for a matching string is different than searching for a file name that matches a string. However, I am open. My main thing: - I know that the code I want is in a file so let me get to the file quickly - I don't know where the code I want is so let me find it as quick as you can For the last one, having only the file name in the search doesn't help me because I don't know whether the match is a string match, a declaration or usage etc. I need to see the content. Changes to this UI will need to be coordinated with UA to make sure the documentation matches.
I have pushed the first cut of this: changed the quick search command (Ctrl+H) to use the search panel. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=27d1c63d79d3840ec41d854216cbbaf12e225318
Cool. I changed the title so that it captures the work that was done to fix this issue (ie. use another dialog)
