Bug 426896 - [Refactoring] Renaming a variable using blank spaces shouldn't be allowed
Summary: [Refactoring] Renaming a variable using blank spaces shouldn't be allowed
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-refactoring (show other bugs)
Version: Next   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-29 09:30 EST by Gustavo Wagner CLA
Modified: 2020-09-04 15:18 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Wagner CLA 2014-01-29 09:30:03 EST
Eclipse IDE for C/C++ Developers
Version: Kepler Service Release 1
Build id: 20130919-0819


Reproducing the bug:


Consider the following code:
======== Original Version ========
float torename = 0;
float GlobalVar_0 = 100;

float f_0() {
    return GlobalVar_0;
}
float f_1() {
    return torename;
}
==================================

Now, let's rename the variable "torename" to "a v"
Applying the refactoring:
========== Refactored ============
float a v = 0;
float GlobalVar_0 = 100;

float f_0() {
    return GlobalVar_0;
}
float f_1() {
    return a v;
}
=================================

The tool shouldn't allow to apply invalid transformations like this. Notice that now the program has a compilation error. It would be good if it was possible to prevent incorrect renames by checking if at least the proposed rename is a well-formed name.

Thanks in advance.
Comment 1 Gustavo Wagner CLA 2014-01-29 11:50:07 EST
Correcting:
* Now, let's rename the variable "torename" to "a v"
Comment 2 Gustavo Wagner CLA 2014-01-29 11:55:10 EST
Ignore this, sorry.
(In reply to Gustavo Wagner from comment #1)
> Correcting:
> * Now, let's rename the variable "torename" to "a v"