Bug 426613 - Add "Compare Parent Version with Workspace" to file context menu
Summary: Add "Compare Parent Version with Workspace" to file context menu
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2014-01-24 14:21 EST by Markus Keller CLA
Modified: 2014-01-27 02:51 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2014-01-24 14:21:43 EST
The context menu on a file in the commit viewer and in the files pane of the History view contains:
- Compare with Version in Ancestor (why not "Compare with Parent Version"?)
- Compare with Workspace

The use case for the first comparison is clear (see what the commit changed).

But the second comparison is a bit strange. It compares the state *after* the given commit with the workspace. I.e. the comparison won't usually include the given commit (assuming the commit is not a descendant of the current HEAD).

I often miss a command that compares the state *before* the commit with the workspace. I.e. "Compare Parent Version with Workspace".

Use case: When I pulled a commit and want to review a change, "Compare with Version in Ancestor" is initially fine. But as soon as I want to fix something I don't like, I'm blocked because the editor for the newer revision is not editable. I wouldn't have that problem if the "new version" side showed the workspace version.
Comment 1 Robin Stocker CLA 2014-01-25 11:47:47 EST
+1, and also for renaming "Compare with Version in Ancestor" to "Compare with Parent Version".
Comment 2 Matthias Sohn CLA 2014-01-27 02:51:55 EST
+1 

command names should be consistent with terms used in the Compare With menu visible in package / project explorer