Bug 426145 - [pmi] Remove GIT Copy to Clipboards
Summary: [pmi] Remove GIT Copy to Clipboards
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Project Management & Portal (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 2014-Q1   Edit
Assignee: Portal Bugzilla Dummy Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 10:47 EST by Ed Willink CLA
Modified: 2014-01-21 17:53 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2014-01-20 10:47:02 EST
It has now happened at least four times.

I want to clone a GIT repo so I go top the PMI Engage page and copy the repo.

Every time it fails because [Copy to clipboard] is not part of the repo name.

I am totally unable to fathom what the purpose of that icon is (apart from annoying me).Please remove it. We all know how to copy text. I certainly don't know how to use a hovertext-less icon. And even after making a mess I can't learn how to do it right next time.
Comment 1 Denis Roy CLA 2014-01-21 08:56:12 EST
-1  I think these links are useful.

It would be nice if there was some feedback upon clicking the image.  I notice that on Gerrit, onmousedown produces the effect of the Copy to Clipboard icon to be pressed down.
Comment 2 Ed Willink CLA 2014-01-21 09:23:47 EST
Can you explain how to actually use the icon?
Comment 3 Denis Roy CLA 2014-01-21 09:48:50 EST
Click the icon -> have clipboard full of Git URI goodness.  Paste as desired.
Comment 4 Ed Willink CLA 2014-01-21 10:05:12 EST
I think there is a cookie that ensures it only works once.

I managed to get a clean URI first time, but then after trying text selects, I couldn't get the icon to give me a clean URI again. Indeed when I changed to another PMI project the icon continued to give a dirty URI from the first project.

The icon is clearly SH*T and not worth the debugging effort. Please delete it.
Comment 5 Wayne Beaton CLA 2014-01-21 10:25:57 EST
(In reply to Denis Roy from comment #1)
> -1  I think these links are useful.
> 
> It would be nice if there was some feedback upon clicking the image.  I
> notice that on Gerrit, onmousedown produces the effect of the Copy to
> Clipboard icon to be pressed down.

The current implementation was inspired by what Gerrit does, but using an existing, but inferior Drupal implementation (with some tweaks).

I'm going to take out the current implementation and--at some point in the future--dig deeper into what Gerrit does. Perhaps there's some JQuery widget or something we can leverage.

(In reply to Ed Willink from comment #4)
> I think there is a cookie that ensures it only works once.

There is no such cookie.
Comment 6 Ed Willink CLA 2014-01-21 10:41:48 EST
(In reply to Wayne Beaton from comment #5)
> (In reply to Ed Willink from comment #4)
> > I think there is a cookie that ensures it only works once.
> 
> There is no such cookie.

THere's certainly a magic thing.

I restarted Firefox went to the PMI of project I'd probably never visited, and clicked on the icon.

When I paste I get to see the URL of the project I had previously failed to click on in Firefox with an icon appended.

So the source is magic and the recipient is probably dependent on how it decodes a rich clipboard selection.
Comment 7 Wayne Beaton CLA 2014-01-21 17:53:13 EST
There's no magic. There is some weirdness that involves Flash and positioning floating divs...

Regardless, I've removed it; the update has been pushed live.

I will open a new bug to consider adopting a more robust implementation along the lines of what Gerrit does.